Re: [PATCH v2] dt-bindings: soc: bcm: Convert raspberrypi,bcm2835-power to Dt schema

[Karan Sanghavi <karansanghvi98@xxxxxxxxx>]

On Wed, Oct 23, 2024 at 09:12:53AM +0200, Krzysztof Kozlowski wrote:
> On Tue, Oct 22, 2024 at 06:17:03PM +0000, Karan Sanghavi wrote:
> > Convert the raspberrypi,bcm2835-power binding to Dt schema
> > 
> > Signed-off-by: Karan Sanghavi <karansanghvi98@xxxxxxxxx>
> > ---
> > Changes in v2:
> > - Added original file maintainers
> > - Removed unnecessary headers from example and formating from description 
> > - Link to v1: https://lore.kernel.org/r/20241019-raspberrypi-bcm2835-power-v1-1-75e924dc3745@xxxxxxxxx
> > ---
> 
> > @@ -0,0 +1,42 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/soc/bcm/raspberrypi,bcm2835-power.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Broadcom BCM2835 power domain driver
> 
> Drop "driver"
> 
> > +
> > +maintainers:
> > +  - Alexander Aring <alex.aring@xxxxxxxxx>
> > +  - Eric Anholt <eric@xxxxxxxxxx>
> > +
> > +description:
> > +  The Raspberry Pi power domain driver manages power for various subsystems
> 
> Drop "driver"
> 
> > +  in the Raspberry Pi BCM2835 SoC.
> > +
> > +properties:
> > +  compatible:
> > +    enum:
> > +      - raspberrypi,bcm2835-power
> > +
> > +  firmware:
> > +    $ref: /schemas/types.yaml#/definitions/phandle
> 
> phandle to what? Missing description.
> 
> > +
> > +  '#power-domain-cells':
> 
> Use consistent quotes, either ' or ".
> 
> > +    const: 1
> > +
> > +required:
> > +  - compatible
> > +  - firmware
> > +  - "#power-domain-cells"
> > +
> > +unevaluatedProperties: false
> > +
> > +examples:
> > +  - |
> > +    power: power {
> 
> Drop label. Node name: power-controller
> 
> I don't think this passes tests because of this. See power-domain.yaml
> schema.
>

Below code is from bcm2711-rpi-4-b.dts decompiled from the dtb file.

firmware {
         compatible = "raspberrypi,bcm2835-firmware\0simple-mfd";
         mboxes = <0x1d>;
         phandle = <0x1e>;
        ...
};

power {
         compatible = "raspberrypi,bcm2835-power";
         firmware = <0x1e>;
         #power-domain-cells = <0x01>;
         phandle = <0x0b>;
};

I had a doubt that as above the raspberrypi,bcm2835-power compatible node
is defined with power keyword, so should I still rename the node as
power-controll or keep it has power?

Also it does passes the dt_binding_check and CHECK_DTBS=y broadcom/bcm2711-rpi-4-b.dtb
but does gives the message as
soc: power: 'ranges' is a required property
so do I need to add the range property here?

> Best regards,
> Krzysztof
>