On 21.10.2024 1:56 PM, Md Sadre Alam wrote: > Use the bitfield macro FIELD_PREP, and GENMASK to > do the shift and mask in one go. This makes the code > more readable. > > Signed-off-by: Md Sadre Alam <quic_mdalam@xxxxxxxxxxx> > --- [...] > + host->cfg1 = FIELD_PREP(NAND_RECOVERY_CYCLES_MASK, 7) | > + FIELD_PREP(BAD_BLOCK_BYTE_NUM_MASK, bad_block_byte) | > + FIELD_PREP(BAD_BLOCK_IN_SPARE_AREA, 0) | > + FIELD_PREP(WR_RD_BSY_GAP_MASK, 2) | > + FIELD_PREP(WIDE_FLASH, wide_bus) | > + FIELD_PREP(ENABLE_BCH_ECC, host->bch_enabled); CS_ACTIVE_BSY is no longer set (not a functional change, but it looks omitted on accident) The rest looks good, thank you! Reviewed-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxxxxxxxx> Konrad
