On 25.10.2024 7:35 AM, Jens Glathe wrote: > > On 18.10.24 16:38, Konrad Dybcio wrote: >> On 13.10.2024 1:54 PM, Jens Glathe via B4 Relay wrote: >>> From: Jens Glathe <jens.glathe@xxxxxxxxxxxxxxxxxxxxxx> >>> >>> Device tree for the Microsoft Windows Dev Kit 2023. This work >>> is based on the initial work of Merck Hung <merckhung@xxxxxxxxx>. >>> >>> The Windows Dev Kit 2023 is a nice little desktop based on sc8280xp. >>> Link: https://learn.microsoft.com/en-us/windows/arm/dev-kit/ >> [...] >> >>> + >>> + pinctrl-names = "default"; >>> + pinctrl-0 = <&wcd_default>; >> property-n >> property-names >> >> (all throughout the file) >> >> [...] >> >>> + pmic-glink { >>> + compatible = "qcom,sc8280xp-pmic-glink", "qcom,pmic-glink"; >>> + >>> + #address-cells = <1>; >>> + #size-cells = <0>; >>> + orientation-gpios = <&tlmm 166 GPIO_ACTIVE_HIGH>, >>> + <&tlmm 49 GPIO_ACTIVE_HIGH>; >>> + >>> + connector@0 { >> Could you add a comment describing which connector is which (see e.g. >> x1e80100-microsoft-romulus.dtsi) >> >> [...] >> >>> +&gpu { >>> + status = "okay"; >>> + >>> + zap-shader { >>> + memory-region = <&gpu_mem>; >>> + firmware-name = "qcom/sc8280xp/MICROSOFT/blackrock/qcdxkmsuc8280.mbn"; >> "microsoft" lowercase would be consistent with other DTs in arm64/qcom > Hmm what about Lenovo X13s. I'll change it to lower case. rg microsoft/ -i arch/arm64/boot/dts/qcom yields lowercase, so let's not step out of the line Konrad
