> > > > Signed-off-by: Wei Fang <wei.fang@xxxxxxx> > > Reviewed-by: Frank Li <Frank.Li@xxxxxxx> > > --- > > v5: no changes > > --- > > drivers/net/ethernet/freescale/enetc/enetc_pci_mdio.c | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git a/drivers/net/ethernet/freescale/enetc/enetc_pci_mdio.c > b/drivers/net/ethernet/freescale/enetc/enetc_pci_mdio.c > > index 2445e35a764a..9968a1e9b5ef 100644 > > --- a/drivers/net/ethernet/freescale/enetc/enetc_pci_mdio.c > > +++ b/drivers/net/ethernet/freescale/enetc/enetc_pci_mdio.c > > @@ -2,6 +2,7 @@ > > /* Copyright 2019 NXP */ > > #include <linux/fsl/enetc_mdio.h> > > #include <linux/of_mdio.h> > > +#include <linux/pinctrl/consumer.h> > > #include "enetc_pf.h" > > > > #define ENETC_MDIO_DEV_ID 0xee01 > > @@ -71,6 +72,8 @@ static int enetc_pci_mdio_probe(struct pci_dev *pdev, > > dev_info(&pdev->dev, "Enabled ERR050089 workaround\n"); > > } > > > > + pinctrl_pm_select_default_state(dev); > > + > > Not an expert on pinctrl by any means.. but is this needed? > Documentation/driver-api/pin-control.rst says: > > | When a device driver is about to probe the device core will automatically > | attempt to issue ``pinctrl_get_select_default()`` on these devices. > | This way driver writers do not need to add any of the boilerplate code > | of the type found below. > > The documentation is obsolete, because pinctrl_get_select_default() > doesn't seem to be the current mechanism through which that happens. But > there is a pinctrl_bind_pins() function in really_probe() which looks > like it does that job. So.. is this needed? I think it is no need, I will remove it, thanks.
