On Thu, Oct 24, 2024 at 06:04:31PM +0100, Conor Dooley wrote: > On Thu, Oct 24, 2024 at 06:38:29AM +0800, Inochi Amaoto wrote: > > On Wed, Oct 23, 2024 at 09:49:34PM +0100, Conor Dooley wrote: > > > On Wed, Oct 23, 2024 at 08:31:24AM +0800, Inochi Amaoto wrote: > > > > On Tue, Oct 22, 2024 at 06:28:06PM +0100, Conor Dooley wrote: > > > > > On Mon, Oct 21, 2024 at 06:36:15PM +0800, Inochi Amaoto wrote: > > > > > > The GMAC IP on SG2044 is almost a standard Synopsys DesignWare MAC > > > > > > with some extra clock. > > > > > > > > > > > > Add necessary compatible string for this device. > > > > > > > > > > > > Signed-off-by: Inochi Amaoto <inochiama@xxxxxxxxx> > > > > > > --- > > > > > > .../devicetree/bindings/net/snps,dwmac.yaml | 1 + > > > > > > .../bindings/net/sophgo,sg2044-dwmac.yaml | 145 ++++++++++++++++++ > > > > > > 2 files changed, 146 insertions(+) > > > > > > create mode 100644 Documentation/devicetree/bindings/net/sophgo,sg2044-dwmac.yaml > > > > > > > > > > > > diff --git a/Documentation/devicetree/bindings/net/snps,dwmac.yaml b/Documentation/devicetree/bindings/net/snps,dwmac.yaml > > > > > > index 3c4007cb65f8..69f6bb36970b 100644 > > > > > > --- a/Documentation/devicetree/bindings/net/snps,dwmac.yaml > > > > > > +++ b/Documentation/devicetree/bindings/net/snps,dwmac.yaml > > > > > > @@ -99,6 +99,7 @@ properties: > > > > > > - snps,dwmac-5.30a > > > > > > - snps,dwxgmac > > > > > > - snps,dwxgmac-2.10 > > > > > > + - sophgo,sg2044-dwmac > > > > > > - starfive,jh7100-dwmac > > > > > > - starfive,jh7110-dwmac > > > > > > > > > > > > diff --git a/Documentation/devicetree/bindings/net/sophgo,sg2044-dwmac.yaml b/Documentation/devicetree/bindings/net/sophgo,sg2044-dwmac.yaml > > > > > > new file mode 100644 > > > > > > index 000000000000..93c41550b0b6 > > > > > > --- /dev/null > > > > > > +++ b/Documentation/devicetree/bindings/net/sophgo,sg2044-dwmac.yaml > > > > > > @@ -0,0 +1,145 @@ > > > > > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > > > > > +%YAML 1.2 > > > > > > +--- > > > > > > +$id: http://devicetree.org/schemas/net/sophgo,sg2044-dwmac.yaml# > > > > > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > > > > > + > > > > > > +title: StarFive JH7110 DWMAC glue layer > > > > > > + > > > > > > +maintainers: > > > > > > + - Inochi Amaoto <inochiama@xxxxxxxxx> > > > > > > + > > > > > > +select: > > > > > > + properties: > > > > > > + compatible: > > > > > > + contains: > > > > > > + enum: > > > > > > + - sophgo,sg2044-dwmac > > > > > > + required: > > > > > > + - compatible > > > > > > + > > > > > > +properties: > > > > > > + compatible: > > > > > > + items: > > > > > > + - const: sophgo,sg2044-dwmac > > > > > > + - const: snps,dwmac-5.30a > > > > > > + > > > > > > + reg: > > > > > > + maxItems: 1 > > > > > > + > > > > > > + clocks: > > > > > > + items: > > > > > > + - description: GMAC main clock > > > > > > + - description: PTP clock > > > > > > + - description: TX clock > > > > > > + > > > > > > + clock-names: > > > > > > + items: > > > > > > + - const: stmmaceth > > > > > > + - const: ptp_ref > > > > > > + - const: tx > > > > > > + > > > > > > + sophgo,syscon: > > > > > > > > > > How many dwmac instances does the sg2044 have? > > > > > > > > > > > > > Only one, there is another 100G dwxgmac instance, but it does not > > > > use this syscon. > > > > > > That dwxgmac is a different device, with a different compatible etc? > > > > Yes, it needs a different compatiable, and maybe a new binding is needed > > since the 100G and 1G IP are different. > > In that case, you don't /need/ a syscon property at all, much less one > with offsets. You can just look up the syscon by compatible and hard > code the offset in the driver. Good, look up the syscon is a good idea. Thanks for this suggestion. Regards, Inochi
