Hi Claudiu,
On Sat, Oct 19, 2024 at 10:48 AM Claudiu <claudiu.beznea@xxxxxxxxx> wrote:
> From: Claudiu Beznea <claudiu.beznea.uj@xxxxxxxxxxxxxx>
>
> Add the DT node for the VBATTB IP along with DT bindings for the clock
> it provides.
>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
> Signed-off-by: Claudiu Beznea <claudiu.beznea.uj@xxxxxxxxxxxxxx>
> ---
>
> Changes in v4:
> - used clock-controller for the vbattb node name
> - move the node near scif0 for ordering
Thanks for the update!
> - set the vbattb_xtal status as disabled to avoid having it exported
> in linux with frequency = 0 in boards that don't use it
That is expected, and perfectly fine.
The clock is referenced from the vbattb node, so IMHO it should not
be disabled.
> - collected tags
> --- a/arch/arm64/boot/dts/renesas/r9a08g045.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r9a08g045.dtsi
> @@ -72,6 +72,18 @@ scif0: serial@1004b800 {
> status = "disabled";
> };
>
> + vbattb: clock-controller@1005c000 {
> + compatible = "renesas,r9a08g045-vbattb";
> + reg = <0 0x1005c000 0 0x1000>;
> + interrupts = <GIC_SPI 43 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&cpg CPG_MOD R9A08G045_VBAT_BCLK>, <&vbattb_xtal>;
> + clock-names = "bclk", "rtx";
> + #clock-cells = <1>;
> + power-domains = <&cpg>;
> + resets = <&cpg R9A08G045_VBAT_BRESETN>;
> + status = "disabled";
> + };
> +
> i2c0: i2c@10090000 {
> compatible = "renesas,riic-r9a08g045", "renesas,riic-r9a09g057";
> reg = <0 0x10090000 0 0x400>;
> @@ -425,4 +437,12 @@ timer {
> interrupt-names = "sec-phys", "phys", "virt", "hyp-phys",
> "hyp-virt";
> };
> +
> + vbattb_xtal: vbattb-xtal {
> + compatible = "fixed-clock";
> + #clock-cells = <0>;
> + /* This value must be overridden by the board. */
> + clock-frequency = <0>;
> + status = "disabled";
Hence please drop this line.
> + };
> };
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
