On 22/10/2024 09:25, Sibi Sankar wrote: > > > On 10/8/24 17:41, Krzysztof Kozlowski wrote: >> On 08/10/2024 14:10, Dmitry Baryshkov wrote: >>> On Tue, Oct 08, 2024 at 08:49:27AM GMT, Krzysztof Kozlowski wrote: >>>> On Mon, Oct 07, 2024 at 11:40:19AM +0530, Sibi Sankar wrote: >>>>> +/* >>>>> + * QCOM_MEM_TYPE_DDR_QOS supports the following states. >>>>> + * >>>>> + * %QCOM_DDR_LEVEL_AUTO: DDR operates with LPM enabled >>>>> + * %QCOM_DDR_LEVEL_PERF: DDR operates with LPM disabled >>>>> + */ >>>>> +#define QCOM_DDR_LEVEL_AUTO 0x0 >>>>> +#define QCOM_DDR_LEVEL_PERF 0x1 >>>> >>>> I could not find any driver using these. Can you point me to usage in >>>> the drivers? >>> >>> It's well hidden. These are the raw values used for DDR_QOS memory. >> >> So not a binding? Then these should be dropped. > > I am not sure why the term "well hidden" was even considered :( > The driver just reads them from dt and passes them along. If you > want the dt to list magic numbers 0/1 instead I can do that as well. > If these are used by FW, then it's fine, although please document it clearly in comment. Best regards, Krzysztof
