> -----Original Message----- > From: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxx> > Sent: Thursday, October 24, 2024 12:26 PM > To: Hennerich, Michael <Michael.Hennerich@xxxxxxxxxx>; Sa, Nuno > <Nuno.Sa@xxxxxxxxxx>; Rob Herring <robh@xxxxxxxxxx>; Krzysztof > Kozlowski <krzk+dt@xxxxxxxxxx>; Conor Dooley <conor+dt@xxxxxxxxxx> > Cc: Trevor Gamblin <tgamblin@xxxxxxxxxxxx>; linux-pwm@xxxxxxxxxxxxxxx; > devicetree@xxxxxxxxxxxxxxx > Subject: [PATCH] dt-bindings: pwm: adi,axi-pwmgen: Increase #pwm-cells to 3 > > [External] > > Using 3 cells allows to pass additional flags and is the normal > abstraction for new PWM descriptions. There are no device trees yet to > adapt to this change. > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxx> > --- Reviewed-by: Nuno Sa <nuno.sa@xxxxxxxxxx> > Hello, > > missed that during review of that new binding. Just noticed that now > when (internally) reviewing a machine dt using that device. > > There is no need for driver adaptions, the pwm core handles both cases > just fine. > > Best regards > Uwe > > Documentation/devicetree/bindings/pwm/adi,axi-pwmgen.yaml | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/pwm/adi,axi-pwmgen.yaml > b/Documentation/devicetree/bindings/pwm/adi,axi-pwmgen.yaml > index ec6115d3796b..aa35209f74cf 100644 > --- a/Documentation/devicetree/bindings/pwm/adi,axi-pwmgen.yaml > +++ b/Documentation/devicetree/bindings/pwm/adi,axi-pwmgen.yaml > @@ -27,7 +27,7 @@ properties: > maxItems: 1 > > "#pwm-cells": > - const: 2 > + const: 3 > > clocks: > maxItems: 1 > @@ -44,5 +44,5 @@ examples: > compatible = "adi,axi-pwmgen-2.00.a"; > reg = <0x44b00000 0x1000>; > clocks = <&spi_clk>; > - #pwm-cells = <2>; > + #pwm-cells = <3>; > }; > -- > 2.45.2
