> -----Original Message----- > From: Krzysztof Kozlowski <krzk@xxxxxxxxxx> > Sent: 2024年10月23日 16:56 > To: Wei Fang <wei.fang@xxxxxxx> > Cc: davem@xxxxxxxxxxxxx; edumazet@xxxxxxxxxx; kuba@xxxxxxxxxx; > pabeni@xxxxxxxxxx; robh@xxxxxxxxxx; krzk+dt@xxxxxxxxxx; > conor+dt@xxxxxxxxxx; Vladimir Oltean <vladimir.oltean@xxxxxxx>; Claudiu > Manoil <claudiu.manoil@xxxxxxx>; Clark Wang <xiaoning.wang@xxxxxxx>; > Frank Li <frank.li@xxxxxxx>; christophe.leroy@xxxxxxxxxx; > linux@xxxxxxxxxxxxxxx; bhelgaas@xxxxxxxxxx; horms@xxxxxxxxxx; > imx@xxxxxxxxxxxxxxx; netdev@xxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx; > linux-kernel@xxxxxxxxxxxxxxx; linux-pci@xxxxxxxxxxxxxxx; > alexander.stein@xxxxxxxxxxxxxxx > Subject: Re: [PATCH v4 net-next 03/13] dt-bindings: net: add bindings for NETC > blocks control > > On 23/10/2024 10:18, Wei Fang wrote: > >>> +maintainers: > >>> + - Wei Fang <wei.fang@xxxxxxx> > >>> + - Clark Wang <xiaoning.wang@xxxxxxx> > >>> + > >>> +properties: > >>> + compatible: > >>> + enum: > >>> + - nxp,imx95-netc-blk-ctrl > >>> + > >>> + reg: > >>> + minItems: 2 > >>> + maxItems: 3 > >> > >> You have one device, why this is flexible? Device either has exactly > >> 2 or exactly 3 IO spaces, not both depending on the context. > >> > > > > There are three register blocks, IERB and PRB are inside NETC IP, but > > NETCMIX is outside NETC. There are dependencies between these three > > blocks, so it is better to configure them in one driver. But for other > > platforms like S32, it does not have NETCMIX, so NETCMIX is optional. > > But how s32 is related here? That's a different device. > The S32 SoC also uses the NETC IP, so this YAML should be compatible with S32 SoC. Or do you mean when S32 NETC is supported, we then add restrictions to the reg property for S32?
