On 10/22/24 09:41, Conor Dooley wrote:
On Mon, Oct 21, 2024 at 11:09:51PM -0700, E Shattow wrote:
Improve function of Star64 bottom network port phy0 with updated delay values.
Initial upstream patches supporting Star64 use the same vendor board support
package parameters known to result in an unreliable bottom network port.
Should I add:
Fixes: 2606bf583b962 ("riscv: dts: starfive: add Star64 board devicetree")
CC: stable@xxxxxxxxxxxxxxx
?
"unreliable" sounds to me like something that is worthy of going to
fixes/stable
Applying as a fix to stable sounds reasonable, thanks. The bottom
network port has always been known by Star64 users in reviews and
discussions to be affected by dropped packets and low network
throughput. If we want to prove correctness does this require expertise
and use of an oscilloscope to characterize the signal timing? Though I
am not sure I got it right, it's not worse than previously was on any of
these Star64 boards in the wild and probably is better for at least some
(if not all).
Notable aside is to mention the re-worked motorcomm driver of
more-recent Linux kernel releases (when compared to the vendor board
support package) dropped the Fast Ethernet configuration parameters on
the reasoning that Fast Ethernet (as compared to Gigabit Ethernet) is
relatively slow enough of a signal that a default delay parameter is
good enough for all use cases. The non-default Fast Ethernet delay
parameter values missing from the upstream effort are not possible to
implement or test for in my effort here, but are no worse or better for
having this patch applied.
-E
