On Mon, Oct 21, 2024 at 04:03:53PM -0700, Melody Olvera wrote: > From: Taniya Das <quic_tdas@xxxxxxxxxxx> > > Add bindings and update documentation for clock rpmh driver on SM8750 > SoCs. > > Signed-off-by: Taniya Das <quic_tdas@xxxxxxxxxxx> > Signed-off-by: Melody Olvera <quic_molvera@xxxxxxxxxxx> > --- A nit, subject: drop second/last, redundant "bindings for". The "dt-bindings" prefix is already stating that these are bindings. See also: https://elixir.bootlin.com/linux/v6.7-rc8/source/Documentation/devicetree/bindings/submitting-patches.rst#L18 This applies to all your patches. There is already CXO clock, so why pad is needed? All of these clocks come via some pad, right? Commit msg could explain here this. Otherwise it just duplicates the diff. Best regards, Krzysztof
