On Mon, Oct 21, 2024 at 04:36:05PM +0300, Vladimir Oltean wrote: > On Mon, Oct 21, 2024 at 03:01:55PM +0200, Christian Marangi wrote: > > It's conceptually similar to mediatek switch but register and bits > > are different. > > Is it impractical to use struct regmap_field to abstract those > differences away and reuse the mt7530 driver's control flow? What is the > relationship between the Airoha and Mediatek IP anyway? The mt7530 > maintainers should also be consulted w.r.t. whether code sharing is in > the common interest (I copied them). That thought crossed my mind while reviewing patch 3. I compared the PMCR and PMSR, a lot of the bits are in completely different places between the two. I didn't check further, but I got the feeling that would invite more complexity. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
