On Sat, Oct 19, 2024 at 07:51:18PM +0000, Karan Sanghavi wrote:
$subject: dt-bindings: soc: bcm: Convert to Dt schema
That's not specific enough about what binding you're converting here.
> +maintainers:
> + - Karan Sanghavi <karansanghvi98@xxxxxxxxx>
Why not the maintainer of the original binding?
> +
> +description: |
The | here serves no purpose, as you have no formatting to preserve.
> + The Raspberry Pi power domain driver manages power for various subsystems
> + in the Raspberry Pi BCM2835 SoC.
> +
> +properties:
> + compatible:
> + enum:
> + - raspberrypi,bcm2835-power
> +
> + firmware:
> + $ref: /schemas/types.yaml#/definitions/phandle
> +
> + '#power-domain-cells':
> + const: 1
> +
> +required:
> + - compatible
> + - firmware
> + - "#power-domain-cells"
> +
> +unevaluatedProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/power/raspberrypi-power.h>
What do you use from this header?
> + power: power {
The label here should be removed, it is never referenced.
Cheers,
Conor.
Attachment:
signature.asc
Description: PGP signature
