On Fri, 13 Mar 2015 23:57:40 -0700
, Frank Rowand <frowand.list@xxxxxxxxx>
wrote:
> From: Frank Rowand <frank.rowand@xxxxxxxxxxxxxx>
>
> Fix bugs pointed out by checkpatch.
>
> Mis-coding of two if statements caused early return from function.
>
> Number of tests completed increased from 102 to 107.
> Number of tests failed increased from 0 to 2.
I was going to send this to Linus right away, but on second thought, it
isn't actually a regression fix. I'm going to queue it up for v4.1 with
the rest of the series instead.
I've also got a bug fix for the new warnings that I'll put in at the
same time.
g.
>
> Signed-off-by: Frank Rowand <frank.rowand@xxxxxxxxxxxxxx>
> ---
> drivers/of/unittest.c | 10 ++++++----
> 1 file changed, 6 insertions(+), 4 deletions(-)
>
> Index: b/drivers/of/unittest.c
> ===================================================================
> --- a/drivers/of/unittest.c
> +++ b/drivers/of/unittest.c
> @@ -762,12 +762,14 @@ static void __init of_selftest_platform_
> irq = platform_get_irq(pdev, 0);
> selftest(irq < 0 && irq != -EPROBE_DEFER, "device parsing error failed - %d\n", irq);
>
> - if (selftest(np = of_find_node_by_path("/testcase-data/platform-tests"),
> - "No testcase data in device tree\n"));
> + np = of_find_node_by_path("/testcase-data/platform-tests");
> + selftest(np, "No testcase data in device tree\n");
> + if (!np)
> return;
>
> - if (selftest(!(rc = device_register(&test_bus)),
> - "testbus registration failed; rc=%i\n", rc));
> + rc = device_register(&test_bus);
> + selftest(!rc, "testbus registration failed; rc=%i\n", rc);
> + if (rc)
> return;
>
> for_each_child_of_node(np, child) {
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
