Hello,
On Sat, Oct 19, 2024 at 11:47:33AM +0300, Claudiu wrote:
> From: Claudiu Beznea <claudiu.beznea.uj@xxxxxxxxxxxxxx>
>
> The RTC IP (RTCA-3) available on the Renesas RZ/G3S SoC has calendar count
> mode and binary count mode (selectable though RCR2.CNTMD) capabilities,
> alarm capabilities, clock error correction capabilities. It can generate
> alarm, period, carry interrupts.
>
> Add a driver for RTCA-3 IP. The driver implements calendar count mode (as
> the conversion b/w RTC and system time is simpler, done with bcd2bin(),
> bin2bcd()), read and set time, read and set alarm, read and set
> an offset.
>
> Signed-off-by: Claudiu Beznea <claudiu.beznea.uj@xxxxxxxxxxxxxx>
I don't know how picky Alexandre is, but there is no S-o-b line for the
patch sender.
> +static struct platform_driver rtca3_platform_driver = {
> + .driver = {
> + .name = "rtc-rtca3",
> + .pm = pm_ptr(&rtca3_pm_ops),
> + .of_match_table = rtca3_of_match,
> + },
> + .probe = rtca3_probe,
> + .remove_new = rtca3_remove,
> +};
Please use .remove here. You just need to drop "_new". See
https://lore.kernel.org/linux-rtc/20241007205803.444994-6-u.kleine-koenig@xxxxxxxxxxxx/
Best regards
Uwe
Attachment:
signature.asc
Description: PGP signature
