Re: [PATCH 04/11] clk: qcom: camcc-qcs615: Add QCS615 camera clock controller driver

["Bryan O'Donoghue" <bryan.odonoghue@xxxxxxxxxx>]

On 18/10/2024 21:22, Dmitry Baryshkov wrote:
> > +static struct gdsc ife_1_gdsc = {
> > +	.gdscr = 0xa004,
> > +	.en_rest_wait_val = 0x2,
> > +	.en_few_wait_val = 0x2,
> > +	.clk_dis_wait_val = 0xf,
> > +	.pd = {
> > +		.name = "ife_1_gdsc",
> > +	},
> > +	.pwrsts = PWRSTS_OFF_ON,
> > +	.flags = POLL_CFG_GDSCR,
> > +};
> Shouldn't IFE GDSCs have titan_top as a parent?

Ack, usually, this looks wrong.

---
bod