Re: [PATCH v2 0/2] gpio: mmio: Support ngpios property

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Oct 17, 2024 at 08:46:07AM +0200, Linus Walleij wrote:
> I thought this generic property was already supported by the
> generic MMIO bindings and code, but no.

I have two issues with the second patch here.

First one is why? What the *practical* issue you have? Can you elaborate
on that?

Second one, is there any other way to avoid duplication of the code so
we have one place of the property parsing?

For the background I have to mention this commit:
55b2395e4e92 ("gpio: mmio: handle "ngpios" properly in bgpio_init()")

If there is an issue, it should be fixed rather than adding a shortcut
with not fully known consequences.

TL;DR: on a brief look the second patch should be reverted (or simply
dropped as it's easy to do while it's on top of the branch.

> It's a pretty obvious usecase to just use some from 0..n
> of a MMIO GPIO bank, so add support for this.

-- 
With Best Regards,
Andy Shevchenko






[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux