Hi, On Fri Oct 18, 2024 at 11:37 AM CEST, Heiko Stübner wrote: > Am Freitag, 18. Oktober 2024, 11:35:51 CEST schrieb Diederik de Haas: > > On Wed Oct 16, 2024 at 2:35 PM CEST, Diederik de Haas wrote: > > > On Wed Oct 16, 2024 at 11:41 AM CEST, Diederik de Haas wrote: > > > > Please revert the 4th patch. > > > > > > > > I must have messed up my testing previously, but BT does not work on the > > > > PineNote with the 4th patch applied and does work with it reverted. > > > > > > FWIW, I figured out what went wrong. > > > My testing was correct, but redo-ing the implementation to make it ready > > > for submission wasn't very smart. > > > > > > With ``shutdown-gpios = <&gpio0 RK_PC4 GPIO_ACTIVE_HIGH>;`` > > > it does work correctly, but I forgot to change GPIO_ACTIVE_LOW to > > > GPIO_ACTIVE_HIGH before submitting. > > > > > > I'll first figure out a better procedure before making a new submission, > > > so the revert is still the best approach IMO. > > > > I've now done a new submission: > > https://lore.kernel.org/linux-rockchip/20241018092237.6774-1-didi.debian@xxxxxxxxx/ > > > > So please don't revert the 4th patch now. > > hehe ok :-) . > I meant to ask if the fix wasn't simply toggling the gpio polarity, and > I guess with your patch you were faster than my question. I already knew that was the fix the moment I opened the other dts(i) files with the same wireless+bt module. While it was tempting to immediately sent the fix, I realized that being (too) eager to sent it out would be a recipe for another screw up. And I wanted to think through why it happened in the first place and that's because my submission process is all manual with an 'insane' long `git send-email` command, hand-crafted. So I better learn `b4` (properly) so my focus can be on the patches and less on the submission process. Making a mistake/screw up sucks, but not learning from them is bad. Cheers, Diederik
Attachment:
signature.asc
Description: PGP signature
