On 18/10/2024 07:17, Troy Mitchell wrote: > > On 2024/10/15 16:08, Krzysztof Kozlowski wrote: >>> + disable_irq(i2c->irq); >> Why? > > I just want to turn on the interrupt when the transmission starts, > and turn off the interrupt after the transmission ends. > The interrupt shutdown in the probe is a starting point > before the transmission starts. > > Is this reasonable? If not, I will modify it. You cut so much context I don't know what this refers to. I will leave it to I2C maintainers, but toggling interrupt on probe is weird. Toggling it for every transfer as well. Best regards, Krzysztof