On 18/10/2024 05:48, Chi-Wen Weng wrote: > This commit adds a generic PWM framework driver for Nuvoton MA35D1 > PWM controller. > > Signed-off-by: Chi-Wen Weng <cwweng.linux@xxxxxxxxx> ... > + > +static const struct of_device_id nuvoton_pwm_of_match[] = { > + { .compatible = "nuvoton,ma35d1-pwm" }, > + {} > +}; > +MODULE_DEVICE_TABLE(of, nuvoton_pwm_of_match); > + > +static struct platform_driver nuvoton_pwm_driver = { > + .probe = nuvoton_pwm_probe, > + .driver = { > + .name = "nuvoton-pwm", > + .of_match_table = nuvoton_pwm_of_match, > + }, > +}; > +module_platform_driver(nuvoton_pwm_driver); > + > +MODULE_ALIAS("platform:nuvoton-pwm"); Drop, not needed and not correct either. If you need platform alias for non-OF binds, this is supposed to match OF ID table. > +MODULE_AUTHOR("Chi-Wen Weng <cwweng@xxxxxxxxxxx>"); > +MODULE_DESCRIPTION("Nuvoton MA35D1 PWM driver"); > +MODULE_LICENSE("GPL"); Best regards, Krzysztof