Re: [PATCH v8 2/2] ARM: dts: mxs: Add descriptions for imx287 based btt3-[012] devices

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Lukasz,

Am 17.10.24 um 10:35 schrieb Lukasz Majewski:
Hi Stefan,

The btt3 device' HW revisions from 0 to 2 use imx287 SoC and are to
some extend similar to already upstreamed XEA devices, hence are
using common imx28-lwe.dtsi file.

New, imx28-btt3.dtsi has been added to embrace common DTS
properties for different HW revisions for this device.

As a result - changes introduced in imx28-btt3-[012].dts are
minimal.

Stefan, do you have comments for this version?

Signed-off-by: Lukasz Majewski <lukma@xxxxxxx>

---
Changes for v2:
- Rename dts file from btt3-[012] to imx28-btt3-[012] to match current
   linux kernel naming convention
- Remove 'wlf,wm8974' from compatible for codec@1a

Changes for v3:
- Keep alphabethical order for Makefile entries

Changes for v4:
- Change compatible for btt3 board (to 'lwn,imx28-btt3')

Changes for v5:
- Combine patch, which adds btt3-[012] with one adding board entry to
   fsl.yaml

Changes for v6:
- Make the patch series for adding entry in fsl.yaml and btt3

Changes for v7:
- Use "panel" property as suggested by the community
- Use panel-timing to specify the display parameters
- Update subject line with correct tags

Changes for v8:
- Use GPIO_ACTIVE_HIGH instead of '0'
- Add the comment regarding mac address specification
- Remove superfluous comment
- Change wifi-en-pin node name
---
  arch/arm/boot/dts/nxp/mxs/Makefile         |   3 +
  arch/arm/boot/dts/nxp/mxs/imx28-btt3-0.dts |  12 +
  arch/arm/boot/dts/nxp/mxs/imx28-btt3-1.dts |   8 +
  arch/arm/boot/dts/nxp/mxs/imx28-btt3-2.dts |  40 +++
  arch/arm/boot/dts/nxp/mxs/imx28-btt3.dtsi  | 313
+++++++++++++++++++++ 5 files changed, 376 insertions(+)
  create mode 100644 arch/arm/boot/dts/nxp/mxs/imx28-btt3-0.dts
  create mode 100644 arch/arm/boot/dts/nxp/mxs/imx28-btt3-1.dts
  create mode 100644 arch/arm/boot/dts/nxp/mxs/imx28-btt3-2.dts
  create mode 100644 arch/arm/boot/dts/nxp/mxs/imx28-btt3.dtsi

...
+
+&ssp1 {
+	compatible = "fsl,imx28-mmc";
+	pinctrl-names = "default";
+	pinctrl-0 = <&ssp1_sdio_pins_a>;
+	bus-width = <4>;
+	no-1-8-v;       /* force 3.3V VIO */
+	pm-ignore-notify;
I think this slipped through?

Regards




[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux