On 16/10/2024 17:30, markus.stockhausen@xxxxxx wrote: > Hi Krzysztof, > > with your feedback on the latest version I will take up the issues from > v2 once again. To be sure that I do not miss anything in upcoming v5 > I will comment on all your feedback. > >>> .... >>> Changes in v2: >>> - new subject >>> - removed patch command sequences >>> - renamed parameter controlled-ports to realtek,controlled-ports >> >> Changelog goes under ---. > > After reading this another 4 times now I think I understand. You mean > "put changelog below signed-off-by". Will do with next patch. --- is under Signed-off-by, so yes, but more importantly under ---. > >>> .... >>> diff --git >>> a/Documentation/devicetree/bindings/phy/realtek,otto-serdes.yaml >>> b/Documentation/devicetree/bindings/phy/realtek,otto-serdes.yaml >>> new file mode 100644 >>> index 000000000000..a72ac206b35f >>> --- /dev/null >>> +++ b/Documentation/devicetree/bindings/phy/realtek,otto-serdes.yaml >> >> Nothing improved. > > In between renamed to compatible "realtek,rtl8380m-serdes.yaml". I hope > that fits the requested naming convention. Yes. > >>> + The driver exposes the SerDes registers different from the hardware >>> + but instead gives a consistent view and programming interface. So >>> + the RTL838x series has 6 ports and 4 pages, the RTL839x has 14 >>> + ports and 12 pages, the RTL930x has 12 ports and 64 pages and the >>> + RTL931x has >>> + 14 ports and 192 pages. >> >> Totally messed wrapping. Please wrap your code as Linux coding style. > > Was restyled in between. If this is still an issue in latest version, please advise. It's ok, the rest as well. Best regards, Krzysztof
