On 10/16/2024 5:25 PM, Uwe Kleine-König wrote: > Hello, > > On Wed, Oct 09, 2024 at 03:13:34PM +0800, Jingyi Wang wrote: >> +static struct platform_driver qcs8300_pinctrl_driver = { >> + .driver = { >> + .name = "qcs8300-tlmm", >> + .of_match_table = qcs8300_pinctrl_of_match, >> + }, >> + .probe = qcs8300_pinctrl_probe, >> + .remove_new = msm_pinctrl_remove, >> +}; > > After commit 0edb555a65d1 ("platform: Make platform_driver::remove() > return void") .remove() is (again) the right callback to implement for > platform drivers. Please just drop "_new". > Will update that, thx! > Best regards > Uwe Thanks, Jingyi