On 15/10/2024 22:25, Conor Dooley wrote: > On Tue, Oct 15, 2024 at 06:09:07PM +0000, Karan Sanghavi wrote: >> Converted the brcm,bcm2835-aux-spi.txt file to >> its respective yaml file format. >> >> Signed-off-by: Karan Sanghavi <karansanghvi98@xxxxxxxxx> >> --- >> v1->v2 : Made the necessary changes in the yaml file >> suggested by Krzysztof Kozlowski >> >> v1: >> - https://lore.kernel.org/all/Zw1Oj1utiBJ9Sosg@Emma/ > > I don't understand this patch. How is it converting a text file to > json schema when all you're doing here is deleting stuff from an > existing yaml file? I guess this is supposed to be v2, but it's all messed up. Karan, 1. Respond to previous review. 2. Prepare v3 incorporating the review. 3. Properly use Git to amend your commit - proficiency in Git is basically a requirement and we won't be teaching this here. This is kernel development, so assumption is that you know how to use Git (and not Github, these are entirely different things). 4. Send v3, do not attach the email to some other versions/threads whatever. Just use 'b4' if you have troubles with 'git format-patch'. Best regards, Krzysztof
