Re: [PATCH 0/2] pwm: brcmstb: Support configurable open-drain mode

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Oct 14, 2024 at 10:05:40PM +0200, Uwe Kleine-König wrote:
> Hello Florian,
> 
> On Fri, Oct 11, 2024 at 07:56:01PM -0700, Florian Fainelli wrote:
> > This patch series updates the pwm-brcmstb driver to not assume an
> > open-drain mode, but instead get that sort of configuration from Device
> > Tree using the 'open-drain' property.
> 
> Just for me to be sure to understand correctly: A kernel without your
> patch #2 behaves identical to a kernel with that patch if the open-drain
> property is present, right?

I don't think it does. Patch #2 breaks the ABI, IMO.

> 
> It's not clear to me why totem-pole is the better default and the commit
> logs don't justify the updated default. Can you improve here?
> 

Best regards,
Krzysztof






[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux