Hi Chen-Yu, Thanks for your help to review the patch. On Tue, 2024-10-15 at 15:54 +0800, Chen-Yu Tsai wrote: > > External email : Please do not click links or open attachments until > you have verified the sender or the content. > Hi, > > On Mon, Oct 14, 2024 at 3:33 PM Yunfei Dong <yunfei.dong@xxxxxxxxxxxx > > wrote: > > > > The working buffer address start and end are calculated in kernel > > side currently, can't calculate the address end if the driver only > > getting the address file handle, not the real physical address. > Need > > to extend the vsi to calculate the address end in scp. > > > > Re-construct some interface and add config to support extend and > non > > extend at the same time. > > --- > > This patch series depends on: > > [1] > https://patchwork.kernel.org/project/linux-mediatek/cover/20241012064333.27269-1-yunfei.dong@xxxxxxxxxxxx > > --- > > Yunfei Dong (6): > > media: mediatek: vcodec: extend h264 video share information > > media: mediatek: vcodec: remove parse nal info in kernel > > media: mediatek: vcodec: remove vsi operation in common interface > > media: mediatek: vcodec: rename vsi to extend vsi > > media: mediatek: vcodec: adding non extend struct > > media: mediatek: vcodec: support extend h264 driver > > This should be reworked so that "adding non extend struct" is not > needed. > "rename vsi to extend vsi" and "extend h264 video share information" > could be combined so that you are "adding" the extended data > structures, > not reworking the existing ones. Otherwise the whole thing breaks > existing > systems until "adding non extend struct" is applied, making the > series > non-bisectable. > > Your advice is very reasonable, I will rewrite the patches again. > ChenYu > Best Regards, Yunfei Dong > > > > .../vcodec/decoder/mtk_vcodec_dec_drv.h | 2 + > > .../decoder/vdec/vdec_h264_req_multi_if.c | 516 > +++++++++++++++++- > > 2 files changed, 493 insertions(+), 25 deletions(-) > > > > -- > > 2.46.0 > > > >
