On Tue, 15 Oct 2024 08:58:47 +0200, Krzysztof Kozlowski wrote: > Commit 904140fa4553 ("dt-bindings: pinctrl: samsung: use Exynos7 > fallbacks for newer wake-up controllers") added > samsung,exynos7-wakeup-eint fallback to some compatibles, so the > intention in the if:then: conditions was to handle the cases: > > 1. Single Exynos7 compatible or Exynos5433+Exynos7 or > Exynos7885+Exynos7: only one interrupt > > 2. Exynos850+Exynos7: no interrupts > > This was not implemented properly however and if:then: block matches > only single Exynos5433 or Exynos7885 compatibles, which do not exist in > DTS anymore, so basically is a no-op and no enforcement on number of > interrupts is made by the binding. > > Fix the if:then: condition so interrupts in the Exynos5433 and > Exynos7885 wake-up pin controller will be properly constrained. > > Fixes: 904140fa4553 ("dt-bindings: pinctrl: samsung: use Exynos7 fallbacks for newer wake-up controllers") > Cc: <stable@xxxxxxxxxxxxxxx> > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> > > --- > > Cc: Igor Belwon <igor.belwon@xxxxxxxxxxxxxxxxxxxxxxxxxx> > --- > .../samsung,pinctrl-wakeup-interrupt.yaml | 19 +++++++++++-------- > 1 file changed, 11 insertions(+), 8 deletions(-) > Acked-by: Rob Herring (Arm) <robh@xxxxxxxxxx>