On Tue, Oct 15, 2024 at 07:52:33AM +0200, Krzysztof Kozlowski wrote: > On Mon, Oct 14, 2024 at 07:38:11AM +0000, Haylen Chu wrote: > > Add devicetree binding documentation for thermal sensors integrated in > > Sophgo CV1800 SoCs. > > > > Signed-off-by: Haylen Chu <heylenay@xxxxxxx> > > --- > > .../thermal/sophgo,cv1800-thermal.yaml | 57 +++++++++++++++++++ > > 1 file changed, 57 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/thermal/sophgo,cv1800-thermal.yaml > > > > diff --git a/Documentation/devicetree/bindings/thermal/sophgo,cv1800-thermal.yaml b/Documentation/devicetree/bindings/thermal/sophgo,cv1800-thermal.yaml > > new file mode 100644 > > index 000000000000..14abeb7a272a > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/thermal/sophgo,cv1800-thermal.yaml > > @@ -0,0 +1,57 @@ > > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/thermal/sophgo,cv1800-thermal.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Sophgo CV1800 on-SoC Thermal Sensor > > + > > +maintainers: > > + - Haylen Chu <heylenay@xxxxxxx> > > + > > +description: Sophgo CV1800 on-SoC thermal sensor > > + > > +$ref: thermal-sensor.yaml# > > + > > +properties: > > + compatible: > > + enum: > > + - sophgo,cv1800-thermal > > Not much improved, judging by other patches there is no "CV1800" SoC, > but that's a family name. Otherwise please point us to bindings or DTS > using this SoC. "cv1800" is referenced in the clock binding[1] and usb binding[2]. I don't think there are other CV1800 SoC variants. Usage of "CV1800" should be specific and unambiguous. Best regards, Haylen Chu [1]: https://elixir.bootlin.com/linux/v6.11.3/source/Documentation/devicetree/bindings/clock/sophgo,cv1800-clk.yaml [2]: https://elixir.bootlin.com/linux/v6.11.3/source/Documentation/devicetree/bindings/usb/dwc2.yaml#L62
