On 15/10/2024 09:54, Xianwei Zhao wrote: > Hi Krzysztof, > Thanks for your reply. > > On 2024/10/15 14:01, Krzysztof Kozlowski wrote: >> [ EXTERNAL EMAIL ] >> >> On Mon, Oct 14, 2024 at 05:05:52PM +0800, Xianwei Zhao wrote: >>> Add a new pinctrl driver for Amlogic A4 SoCs which share >>> the same register layout as the previous Amlogic S4. >>> >>> Signed-off-by: Xianwei Zhao <xianwei.zhao@xxxxxxxxxxx> >>> --- >>> drivers/pinctrl/meson/Kconfig | 6 + >>> drivers/pinctrl/meson/Makefile | 1 + >>> drivers/pinctrl/meson/pinctrl-amlogic-a4.c | 1176 ++++++++++++++++++++++++++++ >>> 3 files changed, 1183 insertions(+) >>> >>> diff --git a/drivers/pinctrl/meson/Kconfig b/drivers/pinctrl/meson/Kconfig >>> index cc397896762c..3e90bb5ec442 100644 >>> --- a/drivers/pinctrl/meson/Kconfig >>> +++ b/drivers/pinctrl/meson/Kconfig >>> @@ -67,6 +67,12 @@ config PINCTRL_MESON_S4 >>> select PINCTRL_MESON_AXG_PMX >>> default y >>> >>> +config PINCTRL_AMLOGIC_A4 >>> + tristate "Amlogic A4 SoC pinctrl driver" >>> + depends on ARM64 >>> + select PINCTRL_MESON_AXG_PMX >>> + default y >>> + >>> config PINCTRL_AMLOGIC_C3 >>> tristate "Amlogic C3 SoC pinctrl driver" >>> depends on ARM64 >>> diff --git a/drivers/pinctrl/meson/Makefile b/drivers/pinctrl/meson/Makefile >>> index 9e538b9ffb9b..c92a65a83344 100644 >>> --- a/drivers/pinctrl/meson/Makefile >>> +++ b/drivers/pinctrl/meson/Makefile >>> @@ -10,5 +10,6 @@ obj-$(CONFIG_PINCTRL_MESON_AXG) += pinctrl-meson-axg.o >>> obj-$(CONFIG_PINCTRL_MESON_G12A) += pinctrl-meson-g12a.o >>> obj-$(CONFIG_PINCTRL_MESON_A1) += pinctrl-meson-a1.o >>> obj-$(CONFIG_PINCTRL_MESON_S4) += pinctrl-meson-s4.o >>> +obj-$(CONFIG_PINCTRL_AMLOGIC_A4) += pinctrl-amlogic-a4.o >>> obj-$(CONFIG_PINCTRL_AMLOGIC_C3) += pinctrl-amlogic-c3.o >>> obj-$(CONFIG_PINCTRL_AMLOGIC_T7) += pinctrl-amlogic-t7.o >>> diff --git a/drivers/pinctrl/meson/pinctrl-amlogic-a4.c b/drivers/pinctrl/meson/pinctrl-amlogic-a4.c >>> new file mode 100644 >>> index 000000000000..dee1ae43edb5 >>> --- /dev/null >>> +++ b/drivers/pinctrl/meson/pinctrl-amlogic-a4.c >>> @@ -0,0 +1,1176 @@ >>> +// SPDX-License-Identifier: (GPL-2.0-only OR MIT) >>> +/* >>> + * Pin controller and GPIO driver for Amlogic A4 SoC. >>> + * >>> + * Copyright (c) 2024 Amlogic, Inc. All rights reserved. >>> + * Author: Xianwei Zhao <xianwei.zhao@xxxxxxxxxxx> >>> + * Huqiang Qin <huqiang.qin@xxxxxxxxxxx> >>> + */ >>> + >>> +#include <dt-bindings/gpio/amlogic-a4-gpio.h> >> >> I do not see any usage of it. >> > > The header file "amlogic-a4-gpio.h" is used by AMLOGIC_PIN and > GPIO_GROUP_V2, The code used is AMLOGIC_GPIO(). > This is binding definition. Then all other defines are not used. AMLOGIC_GPIO is not used by DTS, so how is that a binding? Don't stuff random defines into the bindings. Best regards, Krzysztof
