Hello Cenk,
Please see a few comments below.
On 2024-10-14 20:02, Cenk Uluisik wrote:
Implements a slightly modified rk3588s-orangepi-5b.dts
from the vendor. Unfortunately the &wireless_bluetooth
and &wireless_wlan are not implemented yet.
Bigger parts of the rk3588s-orangepi-5.dts file were
moved into a new rk3588s-orangepi-5.dtsi file, so
that both device trees from the orangepi-5 and 5b
include from it and avoid including from the .dts.
This changes the Orange Pi 5's sdmmc alias to be mmc1,
breaking existing users if they used the /dev/mmc0 device
file, so it's consistent with all the other rk3588 DTS,
which, is also the new default that rockchip wants to use.
https://github.com/orangepi-xunlong/linux-orangepi/commit/bce92d16b230b8e93c2831fb7768839fd7bbab04
Therefore also add the sdhc alias to be mmc0 on the
rk3588s-orangepi-5b.dts.
It would be good to reflow the patch description to use the
76-or-so-column width a bit better.
How does this board differ from the original Orange Pi 5?
- the Orange Pi 5 has a M.2 NVMe M-key PCI 2.0x1
slot (hooked to combphy0_ps) whereas the Orange Pi 5b uses
combphy0_ps
for the WiFi.
- The Orange Pi 5 with the M.2 socket has a regulator defined hooked
to
"GPIO0_C5" (i.e. PCIE_PWREN_H) whereas the Orange Pi 5B has
GPIO0_C5
hooked to BT_WAKE_HOST.
- builtin eMMC storage
- no SPI NOR flash (u-boot, preboot etc. initiates
from within the eMMC
storage)
- ap6275p Wifi module (like the Orange Pi 5 Plus)
- builtin BlueTooth module
Signed-off-by: Cenk Uluisik <cenk.uluisik@xxxxxxxxxxxxxx>
---
arch/arm64/boot/dts/rockchip/Makefile | 1 +
.../boot/dts/rockchip/rk3588s-orangepi-5.dts | 798 +-----------------
...orangepi-5.dts => rk3588s-orangepi-5.dtsi} | 36 +-
.../boot/dts/rockchip/rk3588s-orangepi-5b.dts | 27 +
4 files changed, 73 insertions(+), 789 deletions(-)
Please see my patch [1] that presents use of a set of git-diff(1)
parameters that could also, possibly, reduce the size of this patch
significantly and increase its readability.
[1]
https://lore.kernel.org/linux-rockchip/f3d789c14fe34a53327cac03cd3837e530e21f5c.1728937091.git.dsimic@xxxxxxxxxxx/
