Michal Wilczynski wrote: > Add mailbox device tree node. This work is based on the vendor kernel [1]. > > Link: https://github.com/revyos/thead-kernel.git [1] > > Signed-off-by: Michal Wilczynski <m.wilczynski@xxxxxxxxxxx> > --- > arch/riscv/boot/dts/thead/th1520.dtsi | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/arch/riscv/boot/dts/thead/th1520.dtsi b/arch/riscv/boot/dts/thead/th1520.dtsi > index 6992060e6a54..435f0ab0174d 100644 > --- a/arch/riscv/boot/dts/thead/th1520.dtsi > +++ b/arch/riscv/boot/dts/thead/th1520.dtsi > @@ -555,5 +555,17 @@ portf: gpio-controller@0 { > interrupts = <55 IRQ_TYPE_LEVEL_HIGH>; > }; > }; > + > + mbox_910t: mailbox@ffffc38000 { Hi Michal, Thanks for your patch! Please sort this by address similar to the other nodes. > + compatible = "thead,th1520-mbox"; > + reg = <0xff 0xffc38000 0x0 0x4000>, The documentation[1] calls this area MBOX0_T, but it says it's 24kB long. [1]: https://git.beagleboard.org/beaglev-ahead/beaglev-ahead/-/blob/main/docs/TH1520%20System%20User%20Manual.pdf > + <0xff 0xffc44000 0x0 0x1000>, According to the documentation this is inside the 24kB MBOX1_T area. > + <0xff 0xffc4c000 0x0 0x1000>, This is callod MBOX2_T, but is 8kB long. > + <0xff 0xffc54000 0x0 0x1000>; This is callod MBOX3_T, but is 8kB long. > + reg-names = "local", "remote-icu0", "remote-icu1", "remote-icu2"; Maybe these should match the MBOXn_T names in the documentation? > + interrupt-parent = <&plic>; > + interrupts = <28 IRQ_TYPE_LEVEL_HIGH>; You should probably also add the clocks here: clocks = <&clk CLK_MBOX0>, .., <&clk CLK_MBOX3>; ..and claim them in the driver. Otherwise the clock framework will consider them unused and turn them off without the clk_ignore_unesed kernel command line. /Emil > + #mbox-cells = <2>; > + }; > }; > }; > -- > 2.34.1 > > > _______________________________________________ > linux-riscv mailing list > linux-riscv@xxxxxxxxxxxxxxxxxxx > http://lists.infradead.org/mailman/listinfo/linux-riscv
