On 14/10/2024 09:48, Jan Petrous wrote: > On Mon, Oct 14, 2024 at 08:56:58AM +0200, Krzysztof Kozlowski wrote: >> On 13/10/2024 23:27, Jan Petrous via B4 Relay wrote: >>> From: "Jan Petrous (OSS)" <jan.petrous@xxxxxxxxxxx> >>> >>> Add basic description for DWMAC ethernet IP on NXP S32G2xx, S32G3xx >>> and S32R45 automotive series SoCs. >>> >>> Signed-off-by: Jan Petrous (OSS) <jan.petrous@xxxxxxxxxxx> >>> --- >>> .../devicetree/bindings/net/nxp,s32-dwmac.yaml | 97 ++++++++++++++++++++++ >>> .../devicetree/bindings/net/snps,dwmac.yaml | 1 + >>> 2 files changed, 98 insertions(+) >>> >>> diff --git a/Documentation/devicetree/bindings/net/nxp,s32-dwmac.yaml b/Documentation/devicetree/bindings/net/nxp,s32-dwmac.yaml >>> new file mode 100644 >>> index 000000000000..4c65994cbe8b >>> --- /dev/null >>> +++ b/Documentation/devicetree/bindings/net/nxp,s32-dwmac.yaml >>> @@ -0,0 +1,97 @@ >>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >>> +# Copyright 2021-2024 NXP >>> +%YAML 1.2 >>> +--- >>> +$id: http://devicetree.org/schemas/net/nxp,s32-dwmac.yaml# >>> +$schema: http://devicetree.org/meta-schemas/core.yaml# >>> + >>> +title: NXP S32G2xx/S32G3xx/S32R45 GMAC ethernet controller >>> + >>> +maintainers: >>> + - Jan Petrous (OSS) <jan.petrous@xxxxxxxxxxx> >>> + >>> +description: >>> + This device is a Synopsys DWC IP, integrated on NXP S32G/R SoCs. >>> + >>> +properties: >>> + compatible: >>> + enum: >>> + - nxp,s32g2-dwmac >> >> Where are the other compatibles? Commit msg mentions several devices. > > Well, I removed other compatibles thinking we can re-use this only one > also for other SoCs as, on currect stage, we don't need to do any > SoC specific setup. > > Is it ok or shall I reinsert them? Do not use compatibles from other devices for something else. Please consult writing-bindings. Yes, bring back all relevant compatibles, use proper fallbacks and compatibility when appropriate (hundreds of examples in the kernel). Best regards, Krzysztof
