Re: [PATCH net-next v3 2/2] net: phy: aquantia: allow forcing order of MDI pairs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 11/10/2024 19:12, Andrew Lunn wrote:
This change is breaking networking for one of our Tegra boards and on boot I
am seeing ...

  tegra-mgbe 6800000.ethernet eth0: Register MEM_TYPE_PAGE_POOL RxQ-0
  tegra-mgbe 6800000.ethernet eth0: __stmmac_open: Cannot attach to PHY
  (error: -22)

The issue is that of_property_read_u32() does not return -ENOENT if the
property is missing, it actually returns -EINVAL. See the description of
of_property_read_variable_u32_array() which is called by
of_property_read_u32().

Andrew, can we drop this change from -next until this is fixed?

If it is as simple as s/ENOENT/EINVAL we should just fix it, rather
than revert it.

That also works for me. And yes it is that simple.

Thanks
Jon

--
nvpublic




[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux