On Wed, Oct 09, 2024 at 05:51:12PM +0800, Wei Fang wrote:
> NXP NETC is a multi-function PCIe Root Complex Integrated Endpoint
> (RCiEP) and it contains multiple PCIe functions, such as EMDIO,
> PTP Timer, ENETC PF and VF. Therefore, add these device IDs to
> pci_ids.h
>
> Signed-off-by: Wei Fang <wei.fang@xxxxxxx>
Acked-by: Bjorn Helgaas <bhelgaas@xxxxxxxxxx>
OK as-is, but if you have occasion to update this series for other
reasons:
- Slightly redundant to say "multi-function RCiEP ... contains
multiple functions".
- Mention the drivers that will use these symbols in this commit log
so it's obvious that they're used in multiple places.
- Wrap the commit log to fill 75 columns.
> ---
> include/linux/pci_ids.h | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h
> index 4cf6aaed5f35..acd7ae774913 100644
> --- a/include/linux/pci_ids.h
> +++ b/include/linux/pci_ids.h
> @@ -1556,6 +1556,13 @@
> #define PCI_DEVICE_ID_PHILIPS_SAA7146 0x7146
> #define PCI_DEVICE_ID_PHILIPS_SAA9730 0x9730
>
> +/* NXP has two vendor IDs, the other one is 0x1957 */
> +#define PCI_VENDOR_ID_NXP2 PCI_VENDOR_ID_PHILIPS
> +#define PCI_DEVICE_ID_NXP2_ENETC_PF 0xe101
> +#define PCI_DEVICE_ID_NXP2_NETC_EMDIO 0xee00
> +#define PCI_DEVICE_ID_NXP2_NETC_TIMER 0xee02
> +#define PCI_DEVICE_ID_NXP2_ENETC_VF 0xef00
> +
> #define PCI_VENDOR_ID_EICON 0x1133
> #define PCI_DEVICE_ID_EICON_DIVA20 0xe002
> #define PCI_DEVICE_ID_EICON_DIVA20_U 0xe004
> --
> 2.34.1
>
