On 10/10/2024 8:42 PM, Dmitry Baryshkov wrote:
On Thu, 10 Oct 2024 at 17:57, Krishna Kurapati
<quic_kriskura@xxxxxxxxxxx> wrote:
[...]
+ resets = <&gcc GCC_USB20_PRIM_BCR>;
+
+ interconnects = <&aggre1_noc MASTER_USB2 0 &mc_virt SLAVE_EBI1 0>,
+ <&gem_noc MASTER_APPSS_PROC 0 &config_noc SLAVE_USB2 0>;
+ interconnect-names = "usb-ddr", "apps-usb";
As this is a USB2-only host, shouldn't it also have qcom,select-utmi-as-pipe-clk ?
Hi Dmitry,
Thanks for the catch. You are right, it needs to be added according to
bindings. Since I would be sending another patch after this series to
enable the second controller, would it be fine if I add it in that patch
or do you suggest updating this one.
I think it's better to fix it from the beginning.
Ok, Will send a v2 adding this quirk.
Can you also help review the DTS change. So that I can carry forward and
RB Tags I get to v2.
Regards,
Krishna,
Also I see some others are not using it as well, like sc7280 which also
might need to be updated.
Interesting enough I don't see this option being enabled on SC7280 platforms.
Regards,
Krishna,
+
+ status = "disabled";
+
+ usb_2_dwc3: usb@a400000 {
+ compatible = "snps,dwc3";
+ reg = <0x0 0x0a400000 0x0 0xe000>;
+ interrupts = <GIC_SPI 442 IRQ_TYPE_LEVEL_HIGH>;
+ iommus = <&apps_smmu 0x20 0x0>;
+ phys = <&usb_2_hsphy>;
+ phy-names = "usb2-phy";
+ snps,dis_u2_susphy_quirk;
+ snps,dis_enblslpm_quirk;
+ };
+ };
};
arch_timer: timer {
--
2.34.1
