Re: [PATCH v3 1/9] regmap: Introduce regmap_get_max_register.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 






On 24/03/15 22:36, Mark Brown wrote:
On Tue, Mar 24, 2015 at 10:29:39PM +0000, Srinivas Kandagatla wrote:

This patch introduces regmap_get_max_register() function which would be
used by the infrastructures like eeprom framework built on top of
regmap.

In what way would it be used?
Its used in 2 purposes
1> It is used for sanity check purposes of the register ranges provided via DT/non-DT eeprom data cells.

2> To stop user reading when eeprom binary from /sys/class/eeprom/*/eeprom


+int regmap_get_max_register(struct regmap *map)
+{
+	return map->max_register ? : -EINVAL;
+}

Please write the logic out properly, don't abuse the ternery operator.
Am happy to change it to your preference in next version, but this GNU extensions widely used in the kernel

$  grep -rR "return.*? :" ./linux | wc -l

115



--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]
  Powered by Linux