Il 09/10/24 14:01, Andy-ld Lu ha scritto:
There are modified register settings for STOP_DLY_SEL and POP_EN_CNT, with two new fields added to the compatibility structure to reflect the modifications. For legacy SoCs, also add the original value of 'stop_dly_sel' to the platdata, for unified code setting.
mmc: mtk-sd: Add stop_dly_sel and pop_en_cnt to platform data that's a better title; then, in the commit description, you should describe why stop_dly_sel/pop_en_cnt is overridden (so, why some SoCs need a different value for those registers). Also, this commit should come *before* adding support for MT8196: you first add the two settings in platdata explaining that this is also done in preparation for adding support for the SD/MMC controller found in MT8196, then you add the acutal MT8196 support. For this commit, anyway, the code itself looks good. Cheers, Angelo
