Hi Damien, kernel test robot noticed the following build errors: [auto build test ERROR on pci/next] [also build test ERROR on pci/for-linus mani-mhi/mhi-next linus/master v6.12-rc2 next-20241009] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Damien-Le-Moal/PCI-rockchip-ep-Use-a-macro-to-define-EP-controller-align-feature/20241007-131224 base: https://git.kernel.org/pub/scm/linux/kernel/git/pci/pci.git next patch link: https://lore.kernel.org/r/20241007041218.157516-13-dlemoal%40kernel.org patch subject: [PATCH v3 12/12] PCI: rockchip-ep: Handle PERST# signal in endpoint mode config: sparc-allyesconfig (https://download.01.org/0day-ci/archive/20241010/202410101236.xqI8ZWNd-lkp@xxxxxxxxx/config) compiler: sparc64-linux-gcc (GCC) 14.1.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241010/202410101236.xqI8ZWNd-lkp@xxxxxxxxx/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp@xxxxxxxxx> | Closes: https://lore.kernel.org/oe-kbuild-all/202410101236.xqI8ZWNd-lkp@xxxxxxxxx/ All errors (new ones prefixed by >>): | ^~ drivers/pci/controller/pcie-rockchip-ep.c:255:44: error: invalid use of undefined type 'struct pci_epc_map' 255 | map->map_ofst = map->pci_addr - map->map_pci_addr; | ^~ drivers/pci/controller/pcie-rockchip-ep.c:257:16: error: invalid use of undefined type 'struct pci_epc_map' 257 | if (map->map_ofst + map->pci_size > SZ_1M) | ^~ drivers/pci/controller/pcie-rockchip-ep.c:257:32: error: invalid use of undefined type 'struct pci_epc_map' 257 | if (map->map_ofst + map->pci_size > SZ_1M) | ^~ drivers/pci/controller/pcie-rockchip-ep.c:258:20: error: invalid use of undefined type 'struct pci_epc_map' 258 | map->pci_size = SZ_1M - map->map_ofst; | ^~ drivers/pci/controller/pcie-rockchip-ep.c:258:44: error: invalid use of undefined type 'struct pci_epc_map' 258 | map->pci_size = SZ_1M - map->map_ofst; | ^~ drivers/pci/controller/pcie-rockchip-ep.c:260:12: error: invalid use of undefined type 'struct pci_epc_map' 260 | map->map_size = ALIGN(map->map_ofst + map->pci_size, | ^~ In file included from include/vdso/const.h:5, from include/linux/const.h:4, from include/uapi/linux/kernel.h:6, from include/linux/cache.h:5, from include/linux/time.h:5, from include/linux/stat.h:19, from include/linux/configfs.h:22, from drivers/pci/controller/pcie-rockchip-ep.c:11: drivers/pci/controller/pcie-rockchip-ep.c:260:34: error: invalid use of undefined type 'struct pci_epc_map' 260 | map->map_size = ALIGN(map->map_ofst + map->pci_size, | ^~ include/uapi/linux/const.h:49:44: note: in definition of macro '__ALIGN_KERNEL_MASK' 49 | #define __ALIGN_KERNEL_MASK(x, mask) (((x) + (mask)) & ~(mask)) | ^ include/linux/align.h:8:33: note: in expansion of macro '__ALIGN_KERNEL' 8 | #define ALIGN(x, a) __ALIGN_KERNEL((x), (a)) | ^~~~~~~~~~~~~~ drivers/pci/controller/pcie-rockchip-ep.c:260:25: note: in expansion of macro 'ALIGN' 260 | map->map_size = ALIGN(map->map_ofst + map->pci_size, | ^~~~~ drivers/pci/controller/pcie-rockchip-ep.c:260:50: error: invalid use of undefined type 'struct pci_epc_map' 260 | map->map_size = ALIGN(map->map_ofst + map->pci_size, | ^~ include/uapi/linux/const.h:49:44: note: in definition of macro '__ALIGN_KERNEL_MASK' 49 | #define __ALIGN_KERNEL_MASK(x, mask) (((x) + (mask)) & ~(mask)) | ^ include/linux/align.h:8:33: note: in expansion of macro '__ALIGN_KERNEL' 8 | #define ALIGN(x, a) __ALIGN_KERNEL((x), (a)) | ^~~~~~~~~~~~~~ drivers/pci/controller/pcie-rockchip-ep.c:260:25: note: in expansion of macro 'ALIGN' 260 | map->map_size = ALIGN(map->map_ofst + map->pci_size, | ^~~~~ drivers/pci/controller/pcie-rockchip-ep.c:260:34: error: invalid use of undefined type 'struct pci_epc_map' 260 | map->map_size = ALIGN(map->map_ofst + map->pci_size, | ^~ include/uapi/linux/const.h:49:50: note: in definition of macro '__ALIGN_KERNEL_MASK' 49 | #define __ALIGN_KERNEL_MASK(x, mask) (((x) + (mask)) & ~(mask)) | ^~~~ include/linux/align.h:8:33: note: in expansion of macro '__ALIGN_KERNEL' 8 | #define ALIGN(x, a) __ALIGN_KERNEL((x), (a)) | ^~~~~~~~~~~~~~ drivers/pci/controller/pcie-rockchip-ep.c:260:25: note: in expansion of macro 'ALIGN' 260 | map->map_size = ALIGN(map->map_ofst + map->pci_size, | ^~~~~ drivers/pci/controller/pcie-rockchip-ep.c:260:50: error: invalid use of undefined type 'struct pci_epc_map' 260 | map->map_size = ALIGN(map->map_ofst + map->pci_size, | ^~ include/uapi/linux/const.h:49:50: note: in definition of macro '__ALIGN_KERNEL_MASK' 49 | #define __ALIGN_KERNEL_MASK(x, mask) (((x) + (mask)) & ~(mask)) | ^~~~ include/linux/align.h:8:33: note: in expansion of macro '__ALIGN_KERNEL' 8 | #define ALIGN(x, a) __ALIGN_KERNEL((x), (a)) | ^~~~~~~~~~~~~~ drivers/pci/controller/pcie-rockchip-ep.c:260:25: note: in expansion of macro 'ALIGN' 260 | map->map_size = ALIGN(map->map_ofst + map->pci_size, | ^~~~~ drivers/pci/controller/pcie-rockchip-ep.c:260:34: error: invalid use of undefined type 'struct pci_epc_map' 260 | map->map_size = ALIGN(map->map_ofst + map->pci_size, | ^~ include/uapi/linux/const.h:49:61: note: in definition of macro '__ALIGN_KERNEL_MASK' 49 | #define __ALIGN_KERNEL_MASK(x, mask) (((x) + (mask)) & ~(mask)) | ^~~~ include/linux/align.h:8:33: note: in expansion of macro '__ALIGN_KERNEL' 8 | #define ALIGN(x, a) __ALIGN_KERNEL((x), (a)) | ^~~~~~~~~~~~~~ drivers/pci/controller/pcie-rockchip-ep.c:260:25: note: in expansion of macro 'ALIGN' 260 | map->map_size = ALIGN(map->map_ofst + map->pci_size, | ^~~~~ drivers/pci/controller/pcie-rockchip-ep.c:260:50: error: invalid use of undefined type 'struct pci_epc_map' 260 | map->map_size = ALIGN(map->map_ofst + map->pci_size, | ^~ include/uapi/linux/const.h:49:61: note: in definition of macro '__ALIGN_KERNEL_MASK' 49 | #define __ALIGN_KERNEL_MASK(x, mask) (((x) + (mask)) & ~(mask)) | ^~~~ include/linux/align.h:8:33: note: in expansion of macro '__ALIGN_KERNEL' 8 | #define ALIGN(x, a) __ALIGN_KERNEL((x), (a)) | ^~~~~~~~~~~~~~ drivers/pci/controller/pcie-rockchip-ep.c:260:25: note: in expansion of macro 'ALIGN' 260 | map->map_size = ALIGN(map->map_ofst + map->pci_size, | ^~~~~ drivers/pci/controller/pcie-rockchip-ep.c: In function 'rockchip_pcie_ep_perst_irq_thread': >> drivers/pci/controller/pcie-rockchip-ep.c:631:9: error: implicit declaration of function 'irq_set_irq_type'; did you mean 'irq_set_irq_wake'? [-Wimplicit-function-declaration] 631 | irq_set_irq_type(ep->perst_irq, | ^~~~~~~~~~~~~~~~ | irq_set_irq_wake drivers/pci/controller/pcie-rockchip-ep.c: In function 'rockchip_pcie_ep_setup_irq': >> drivers/pci/controller/pcie-rockchip-ep.c:655:9: error: implicit declaration of function 'irq_set_status_flags' [-Wimplicit-function-declaration] 655 | irq_set_status_flags(ep->perst_irq, IRQ_NOAUTOEN); | ^~~~~~~~~~~~~~~~~~~~ >> drivers/pci/controller/pcie-rockchip-ep.c:655:45: error: 'IRQ_NOAUTOEN' undeclared (first use in this function); did you mean 'IRQF_NO_AUTOEN'? 655 | irq_set_status_flags(ep->perst_irq, IRQ_NOAUTOEN); | ^~~~~~~~~~~~ | IRQF_NO_AUTOEN drivers/pci/controller/pcie-rockchip-ep.c:655:45: note: each undeclared identifier is reported only once for each function it appears in drivers/pci/controller/pcie-rockchip-ep.c: At top level: drivers/pci/controller/pcie-rockchip-ep.c:685:10: error: 'const struct pci_epc_ops' has no member named 'map_align' 685 | .map_align = rockchip_pcie_ep_map_align, | ^~~~~~~~~ drivers/pci/controller/pcie-rockchip-ep.c:685:27: error: initialization of 'int (*)(struct pci_epc *, u8, u8, phys_addr_t, u64, size_t)' {aka 'int (*)(struct pci_epc *, unsigned char, unsigned char, long long unsigned int, long long unsigned int, long unsigned int)'} from incompatible pointer type 'int (*)(struct pci_epc *, u8, u8, struct pci_epc_map *)' {aka 'int (*)(struct pci_epc *, unsigned char, unsigned char, struct pci_epc_map *)'} [-Wincompatible-pointer-types] 685 | .map_align = rockchip_pcie_ep_map_align, | ^~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/pci/controller/pcie-rockchip-ep.c:685:27: note: (near initialization for 'rockchip_pcie_epc_ops.map_addr') drivers/pci/controller/pcie-rockchip-ep.c:686:27: warning: initialized field overwritten [-Woverride-init] 686 | .map_addr = rockchip_pcie_ep_map_addr, | ^~~~~~~~~~~~~~~~~~~~~~~~~ drivers/pci/controller/pcie-rockchip-ep.c:686:27: note: (near initialization for 'rockchip_pcie_epc_ops.map_addr') vim +631 drivers/pci/controller/pcie-rockchip-ep.c 618 619 static irqreturn_t rockchip_pcie_ep_perst_irq_thread(int irq, void *data) 620 { 621 struct pci_epc *epc = data; 622 struct rockchip_pcie_ep *ep = epc_get_drvdata(epc); 623 struct rockchip_pcie *rockchip = &ep->rockchip; 624 u32 perst = gpiod_get_value(rockchip->ep_gpio); 625 626 if (perst) 627 rockchip_pcie_ep_perst_assert(ep); 628 else 629 rockchip_pcie_ep_perst_deassert(ep); 630 > 631 irq_set_irq_type(ep->perst_irq, 632 (perst ? IRQF_TRIGGER_HIGH : IRQF_TRIGGER_LOW)); 633 634 return IRQ_HANDLED; 635 } 636 637 static int rockchip_pcie_ep_setup_irq(struct pci_epc *epc) 638 { 639 struct rockchip_pcie_ep *ep = epc_get_drvdata(epc); 640 struct rockchip_pcie *rockchip = &ep->rockchip; 641 struct device *dev = rockchip->dev; 642 int ret; 643 644 if (!rockchip->ep_gpio) 645 return 0; 646 647 /* PCIe reset interrupt */ 648 ep->perst_irq = gpiod_to_irq(rockchip->ep_gpio); 649 if (ep->perst_irq < 0) { 650 dev_err(dev, "No corresponding IRQ for PERST GPIO\n"); 651 return ep->perst_irq; 652 } 653 654 ep->perst_asserted = true; > 655 irq_set_status_flags(ep->perst_irq, IRQ_NOAUTOEN); 656 ret = devm_request_threaded_irq(dev, ep->perst_irq, NULL, 657 rockchip_pcie_ep_perst_irq_thread, 658 IRQF_TRIGGER_HIGH | IRQF_ONESHOT, 659 "pcie-ep-perst", epc); 660 if (ret) { 661 dev_err(dev, "Request PERST GPIO IRQ failed %d\n", ret); 662 return ret; 663 } 664 665 return 0; 666 } 667 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki
