Hi Damien, kernel test robot noticed the following build errors: [auto build test ERROR on pci/next] [also build test ERROR on pci/for-linus mani-mhi/mhi-next linus/master v6.12-rc2 next-20241009] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Damien-Le-Moal/PCI-rockchip-ep-Use-a-macro-to-define-EP-controller-align-feature/20241007-131224 base: https://git.kernel.org/pub/scm/linux/kernel/git/pci/pci.git next patch link: https://lore.kernel.org/r/20241007041218.157516-6-dlemoal%40kernel.org patch subject: [PATCH v3 05/12] PCI: rockchip-ep: Implement the .map_align() controller operation config: loongarch-allmodconfig (https://download.01.org/0day-ci/archive/20241010/202410101044.3nr7XIR9-lkp@xxxxxxxxx/config) compiler: loongarch64-linux-gcc (GCC) 14.1.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241010/202410101044.3nr7XIR9-lkp@xxxxxxxxx/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp@xxxxxxxxx> | Closes: https://lore.kernel.org/oe-kbuild-all/202410101044.3nr7XIR9-lkp@xxxxxxxxx/ All error/warnings (new ones prefixed by >>): >> drivers/pci/controller/pcie-rockchip-ep.c:239:46: warning: 'struct pci_epc_map' declared inside parameter list will not be visible outside of this definition or declaration 239 | struct pci_epc_map *map) | ^~~~~~~~~~~ drivers/pci/controller/pcie-rockchip-ep.c: In function 'rockchip_pcie_ep_map_align': >> drivers/pci/controller/pcie-rockchip-ep.c:245:52: error: invalid use of undefined type 'struct pci_epc_map' 245 | map->pci_addr, map->pci_size); | ^~ drivers/pci/controller/pcie-rockchip-ep.c:245:67: error: invalid use of undefined type 'struct pci_epc_map' 245 | map->pci_addr, map->pci_size); | ^~ drivers/pci/controller/pcie-rockchip-ep.c:247:12: error: invalid use of undefined type 'struct pci_epc_map' 247 | map->map_pci_addr = map->pci_addr & ~((1ULL << num_bits) - 1); | ^~ drivers/pci/controller/pcie-rockchip-ep.c:247:32: error: invalid use of undefined type 'struct pci_epc_map' 247 | map->map_pci_addr = map->pci_addr & ~((1ULL << num_bits) - 1); | ^~ drivers/pci/controller/pcie-rockchip-ep.c:248:12: error: invalid use of undefined type 'struct pci_epc_map' 248 | map->map_ofst = map->pci_addr - map->map_pci_addr; | ^~ drivers/pci/controller/pcie-rockchip-ep.c:248:28: error: invalid use of undefined type 'struct pci_epc_map' 248 | map->map_ofst = map->pci_addr - map->map_pci_addr; | ^~ drivers/pci/controller/pcie-rockchip-ep.c:248:44: error: invalid use of undefined type 'struct pci_epc_map' 248 | map->map_ofst = map->pci_addr - map->map_pci_addr; | ^~ drivers/pci/controller/pcie-rockchip-ep.c:250:16: error: invalid use of undefined type 'struct pci_epc_map' 250 | if (map->map_ofst + map->pci_size > SZ_1M) | ^~ drivers/pci/controller/pcie-rockchip-ep.c:250:32: error: invalid use of undefined type 'struct pci_epc_map' 250 | if (map->map_ofst + map->pci_size > SZ_1M) | ^~ drivers/pci/controller/pcie-rockchip-ep.c:251:20: error: invalid use of undefined type 'struct pci_epc_map' 251 | map->pci_size = SZ_1M - map->map_ofst; | ^~ drivers/pci/controller/pcie-rockchip-ep.c:251:44: error: invalid use of undefined type 'struct pci_epc_map' 251 | map->pci_size = SZ_1M - map->map_ofst; | ^~ drivers/pci/controller/pcie-rockchip-ep.c:253:12: error: invalid use of undefined type 'struct pci_epc_map' 253 | map->map_size = ALIGN(map->map_ofst + map->pci_size, | ^~ In file included from include/vdso/const.h:5, from include/linux/const.h:4, from include/uapi/linux/kernel.h:6, from include/linux/cache.h:5, from include/linux/time.h:5, from include/linux/stat.h:19, from include/linux/configfs.h:22, from drivers/pci/controller/pcie-rockchip-ep.c:11: drivers/pci/controller/pcie-rockchip-ep.c:253:34: error: invalid use of undefined type 'struct pci_epc_map' 253 | map->map_size = ALIGN(map->map_ofst + map->pci_size, | ^~ include/uapi/linux/const.h:49:44: note: in definition of macro '__ALIGN_KERNEL_MASK' 49 | #define __ALIGN_KERNEL_MASK(x, mask) (((x) + (mask)) & ~(mask)) | ^ include/linux/align.h:8:33: note: in expansion of macro '__ALIGN_KERNEL' 8 | #define ALIGN(x, a) __ALIGN_KERNEL((x), (a)) | ^~~~~~~~~~~~~~ drivers/pci/controller/pcie-rockchip-ep.c:253:25: note: in expansion of macro 'ALIGN' 253 | map->map_size = ALIGN(map->map_ofst + map->pci_size, | ^~~~~ drivers/pci/controller/pcie-rockchip-ep.c:253:50: error: invalid use of undefined type 'struct pci_epc_map' 253 | map->map_size = ALIGN(map->map_ofst + map->pci_size, | ^~ include/uapi/linux/const.h:49:44: note: in definition of macro '__ALIGN_KERNEL_MASK' 49 | #define __ALIGN_KERNEL_MASK(x, mask) (((x) + (mask)) & ~(mask)) | ^ include/linux/align.h:8:33: note: in expansion of macro '__ALIGN_KERNEL' 8 | #define ALIGN(x, a) __ALIGN_KERNEL((x), (a)) | ^~~~~~~~~~~~~~ drivers/pci/controller/pcie-rockchip-ep.c:253:25: note: in expansion of macro 'ALIGN' 253 | map->map_size = ALIGN(map->map_ofst + map->pci_size, | ^~~~~ drivers/pci/controller/pcie-rockchip-ep.c:253:34: error: invalid use of undefined type 'struct pci_epc_map' 253 | map->map_size = ALIGN(map->map_ofst + map->pci_size, | ^~ include/uapi/linux/const.h:49:50: note: in definition of macro '__ALIGN_KERNEL_MASK' 49 | #define __ALIGN_KERNEL_MASK(x, mask) (((x) + (mask)) & ~(mask)) | ^~~~ include/linux/align.h:8:33: note: in expansion of macro '__ALIGN_KERNEL' 8 | #define ALIGN(x, a) __ALIGN_KERNEL((x), (a)) | ^~~~~~~~~~~~~~ drivers/pci/controller/pcie-rockchip-ep.c:253:25: note: in expansion of macro 'ALIGN' 253 | map->map_size = ALIGN(map->map_ofst + map->pci_size, | ^~~~~ drivers/pci/controller/pcie-rockchip-ep.c:253:50: error: invalid use of undefined type 'struct pci_epc_map' 253 | map->map_size = ALIGN(map->map_ofst + map->pci_size, | ^~ include/uapi/linux/const.h:49:50: note: in definition of macro '__ALIGN_KERNEL_MASK' 49 | #define __ALIGN_KERNEL_MASK(x, mask) (((x) + (mask)) & ~(mask)) | ^~~~ include/linux/align.h:8:33: note: in expansion of macro '__ALIGN_KERNEL' 8 | #define ALIGN(x, a) __ALIGN_KERNEL((x), (a)) | ^~~~~~~~~~~~~~ drivers/pci/controller/pcie-rockchip-ep.c:253:25: note: in expansion of macro 'ALIGN' 253 | map->map_size = ALIGN(map->map_ofst + map->pci_size, | ^~~~~ drivers/pci/controller/pcie-rockchip-ep.c:253:34: error: invalid use of undefined type 'struct pci_epc_map' 253 | map->map_size = ALIGN(map->map_ofst + map->pci_size, | ^~ include/uapi/linux/const.h:49:61: note: in definition of macro '__ALIGN_KERNEL_MASK' 49 | #define __ALIGN_KERNEL_MASK(x, mask) (((x) + (mask)) & ~(mask)) | ^~~~ include/linux/align.h:8:33: note: in expansion of macro '__ALIGN_KERNEL' 8 | #define ALIGN(x, a) __ALIGN_KERNEL((x), (a)) | ^~~~~~~~~~~~~~ drivers/pci/controller/pcie-rockchip-ep.c:253:25: note: in expansion of macro 'ALIGN' 253 | map->map_size = ALIGN(map->map_ofst + map->pci_size, | ^~~~~ drivers/pci/controller/pcie-rockchip-ep.c:253:50: error: invalid use of undefined type 'struct pci_epc_map' 253 | map->map_size = ALIGN(map->map_ofst + map->pci_size, | ^~ include/uapi/linux/const.h:49:61: note: in definition of macro '__ALIGN_KERNEL_MASK' 49 | #define __ALIGN_KERNEL_MASK(x, mask) (((x) + (mask)) & ~(mask)) | ^~~~ include/linux/align.h:8:33: note: in expansion of macro '__ALIGN_KERNEL' 8 | #define ALIGN(x, a) __ALIGN_KERNEL((x), (a)) | ^~~~~~~~~~~~~~ drivers/pci/controller/pcie-rockchip-ep.c:253:25: note: in expansion of macro 'ALIGN' 253 | map->map_size = ALIGN(map->map_ofst + map->pci_size, | ^~~~~ drivers/pci/controller/pcie-rockchip-ep.c: At top level: >> drivers/pci/controller/pcie-rockchip-ep.c:482:10: error: 'const struct pci_epc_ops' has no member named 'map_align' 482 | .map_align = rockchip_pcie_ep_map_align, | ^~~~~~~~~ >> drivers/pci/controller/pcie-rockchip-ep.c:482:27: error: initialization of 'int (*)(struct pci_epc *, u8, u8, phys_addr_t, u64, size_t)' {aka 'int (*)(struct pci_epc *, unsigned char, unsigned char, long long unsigned int, long long unsigned int, long unsigned int)'} from incompatible pointer type 'int (*)(struct pci_epc *, u8, u8, struct pci_epc_map *)' {aka 'int (*)(struct pci_epc *, unsigned char, unsigned char, struct pci_epc_map *)'} [-Wincompatible-pointer-types] 482 | .map_align = rockchip_pcie_ep_map_align, | ^~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/pci/controller/pcie-rockchip-ep.c:482:27: note: (near initialization for 'rockchip_pcie_epc_ops.map_addr') drivers/pci/controller/pcie-rockchip-ep.c:483:27: warning: initialized field overwritten [-Woverride-init] 483 | .map_addr = rockchip_pcie_ep_map_addr, | ^~~~~~~~~~~~~~~~~~~~~~~~~ drivers/pci/controller/pcie-rockchip-ep.c:483:27: note: (near initialization for 'rockchip_pcie_epc_ops.map_addr') vim +245 drivers/pci/controller/pcie-rockchip-ep.c 237 238 static int rockchip_pcie_ep_map_align(struct pci_epc *epc, u8 fn, u8 vfn, > 239 struct pci_epc_map *map) 240 { 241 struct rockchip_pcie_ep *ep = epc_get_drvdata(epc); 242 int num_bits; 243 244 num_bits = rockchip_pcie_ep_ob_atu_num_bits(&ep->rockchip, > 245 map->pci_addr, map->pci_size); 246 247 map->map_pci_addr = map->pci_addr & ~((1ULL << num_bits) - 1); 248 map->map_ofst = map->pci_addr - map->map_pci_addr; 249 250 if (map->map_ofst + map->pci_size > SZ_1M) 251 map->pci_size = SZ_1M - map->map_ofst; 252 253 map->map_size = ALIGN(map->map_ofst + map->pci_size, 254 ROCKCHIP_PCIE_AT_SIZE_ALIGN); 255 256 return 0; 257 } 258 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki
