On Mi, 2024-10-09 at 14:05 +0800, Ryan Chen wrote: > Add AST2700 clock controller driver and also use axiliary > device framework register the reset controller driver. > Due to clock and reset using the same register region. > > Signed-off-by: Ryan Chen <ryan_chen@xxxxxxxxxxxxxx> > --- > drivers/clk/Kconfig | 8 + > drivers/clk/Makefile | 1 + > drivers/clk/clk-ast2700.c | 1554 +++++++++++++++++++++++++++++++++++++ > 3 files changed, 1563 insertions(+) > create mode 100644 drivers/clk/clk-ast2700.c > [...] > diff --git a/drivers/clk/clk-ast2700.c b/drivers/clk/clk-ast2700.c > new file mode 100644 > index 000000000000..ef1f939b1c9f > --- /dev/null > +++ b/drivers/clk/clk-ast2700.c > @@ -0,0 +1,1554 @@ [...] > +static void aspeed_reset_unregister_adev(void *_adev) > +{ > + struct auxiliary_device *adev = _adev; > + > + auxiliary_device_delete(adev); > + auxiliary_device_uninit(adev); > +} > + > +static void aspeed_reset_adev_release(struct device *dev) > +{ > + struct auxiliary_device *adev = to_auxiliary_dev(dev); > + > + kfree(adev); > +} > + > +static int aspeed_reset_controller_register(struct device *clk_dev, > + void __iomem *base, const char *adev_name) > +{ > + struct auxiliary_device *adev; > + int ret; > + > + adev = kzalloc(sizeof(*adev), GFP_KERNEL); > + if (!adev) > + return -ENOMEM; > + > + adev->name = adev_name; > + adev->dev.parent = clk_dev; > + adev->dev.release = aspeed_reset_adev_release; > + adev->id = 666u; > + > + ret = auxiliary_device_init(adev); > + if (ret) { > + kfree(adev); > + return ret; > + } > + > + ret = auxiliary_device_add(adev); > + if (ret) { > + auxiliary_device_uninit(adev); > + return ret; > + } > + > + adev->dev.platform_data = (__force void *)base; > + > + return devm_add_action_or_reset(clk_dev, aspeed_reset_unregister_adev, adev); > +} Should this be moved into reset-aspeed.c? regards Philipp