Re: [PATCH v2 3/5] arm64: dts: rockchip: rk3368: Drop rockchip prefix from s-p-c PMIC property

[Dragan Simic <dsimic@xxxxxxxxxxx>]

Hello Diederik,

On 2024-10-08 12:48, Diederik de Haas wrote:
> Property 'rockchip,system-power-controller' was deprecated in commit
> 961748bb1555 ("dt-bindings: mfd: rk8xx: Deprecate
> rockchip,system-power-controller")
>
> in the "rockchip,rk{805,808,809,817,818}.yaml" mtd bindings and its
> replacement is (just) 'system-power-controller'.
>
> Update the rk3368 DT files which still used the deprecated variant.
>
> Signed-off-by: Diederik de Haas <didi.debian@xxxxxxxxx>

This patch is looking good to me, all changes introduced to the
board dts files are fine and pretty much straightforward.  Thanks
for this patch, and please feel free to include:

Reviewed-by: Dragan Simic <dsimic@xxxxxxxxxxx>

See also a related rk8xx MFD patch that I just submitted. [1]
It builds upon the changes you introduced and helps with saving
a few CPU cycles while probing.

[1] 
https://lore.kernel.org/linux-rockchip/08d4e88974c205eba124086ce156622e2e4cdc20.1728397516.git.dsimic@xxxxxxxxxxx/T/#u

> ---
> changes in v2:
> - rephrased commit message a bit
>
>  arch/arm64/boot/dts/rockchip/rk3368-geekbox.dts | 2 +-
>  arch/arm64/boot/dts/rockchip/rk3368-lion.dtsi   | 2 +-
>  arch/arm64/boot/dts/rockchip/rk3368-px5-evb.dts | 2 +-
>  3 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk3368-geekbox.dts
> b/arch/arm64/boot/dts/rockchip/rk3368-geekbox.dts
> index 029b8e22e709..03ebf66e9bfc 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3368-geekbox.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3368-geekbox.dts
> @@ -113,7 +113,7 @@ rk808: pmic@1b {
>  		pinctrl-0 = <&pmic_int>, <&pmic_sleep>;
>  		interrupt-parent = <&gpio0>;
>  		interrupts = <RK_PA5 IRQ_TYPE_LEVEL_LOW>;
> -		rockchip,system-power-controller;
> +		system-power-controller;
>  		vcc1-supply = <&vcc_sys>;
>  		vcc2-supply = <&vcc_sys>;
>  		vcc3-supply = <&vcc_sys>;
> diff --git a/arch/arm64/boot/dts/rockchip/rk3368-lion.dtsi
> b/arch/arm64/boot/dts/rockchip/rk3368-lion.dtsi
> index 8ac8acf4082d..dbf9fef9bc36 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3368-lion.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/rk3368-lion.dtsi
> @@ -179,7 +179,7 @@ rk808: pmic@1b {
>  		#clock-cells = <1>;
>  		pinctrl-names = "default";
>  		pinctrl-0 = <&pmic_int_l>, <&pmic_sleep>;
> -		rockchip,system-power-controller;
> +		system-power-controller;
>  		vcc1-supply = <&vcc_sys>;
>  		vcc2-supply = <&vcc_sys>;
>  		vcc3-supply = <&vcc_sys>;
> diff --git a/arch/arm64/boot/dts/rockchip/rk3368-px5-evb.dts
> b/arch/arm64/boot/dts/rockchip/rk3368-px5-evb.dts
> index 29df84b81552..26de79388db8 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3368-px5-evb.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3368-px5-evb.dts
> @@ -73,7 +73,7 @@ rk808: pmic@1b {
>  		interrupts = <RK_PA5 IRQ_TYPE_LEVEL_LOW>;
>  		pinctrl-names = "default";
>  		pinctrl-0 = <&pmic_int>, <&pmic_sleep>;
> -		rockchip,system-power-controller;
> +		system-power-controller;
>  		vcc1-supply = <&vcc_sys>;
>  		vcc2-supply = <&vcc_sys>;
>  		vcc3-supply = <&vcc_sys>;