Re: [PATCH v2 1/5] arm64: dts: rockchip: px30: Drop rockchip prefix from s-p-c PMIC property

[Dragan Simic <dsimic@xxxxxxxxxxx>]

Hello Diederik,

On 2024-10-08 12:48, Diederik de Haas wrote:
> Property 'rockchip,system-power-controller' was deprecated in commit
> 961748bb1555 ("dt-bindings: mfd: rk8xx: Deprecate
> rockchip,system-power-controller")
>
> in the "rockchip,rk{805,808,809,817,818}.yaml" mtd bindings and its
> replacement is (just) 'system-power-controller'.
>
> Update the px30 DT files which still used the deprecated variant.
>
> Signed-off-by: Diederik de Haas <didi.debian@xxxxxxxxx>

This patch is looking good to me, all changes introduced to the
board dts files are fine and pretty much straightforward.  Thanks
for this patch, and please feel free to include:

Reviewed-by: Dragan Simic <dsimic@xxxxxxxxxxx>

See also a related rk8xx MFD patch that I just submitted. [1]
It builds upon the changes you introduced and helps with saving
a few CPU cycles while probing.

[1] 
https://lore.kernel.org/linux-rockchip/08d4e88974c205eba124086ce156622e2e4cdc20.1728397516.git.dsimic@xxxxxxxxxxx/T/#u

> ---
> changes in v2:
> - rephrased commit message a bit
>
>  arch/arm64/boot/dts/rockchip/px30-engicam-px30-core.dtsi | 2 +-
>  arch/arm64/boot/dts/rockchip/px30-evb.dts                | 2 +-
>  arch/arm64/boot/dts/rockchip/px30-firefly-jd4-core.dtsi  | 2 +-
>  arch/arm64/boot/dts/rockchip/px30-ringneck.dtsi          | 2 +-
>  4 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/rockchip/px30-engicam-px30-core.dtsi
> b/arch/arm64/boot/dts/rockchip/px30-engicam-px30-core.dtsi
> index 5eecbefa8a33..dd715d22d4d2 100644
> --- a/arch/arm64/boot/dts/rockchip/px30-engicam-px30-core.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/px30-engicam-px30-core.dtsi
> @@ -50,7 +50,7 @@ rk809: pmic@20 {
>  		interrupts = <RK_PA7 IRQ_TYPE_LEVEL_LOW>;
>  		pinctrl-names = "default";
>  		pinctrl-0 = <&pmic_int>;
> -		rockchip,system-power-controller;
> +		system-power-controller;
>  		wakeup-source;
>  		#clock-cells = <1>;
>  		clock-output-names = "rk808-clkout1", "rk808-clkout2";
> diff --git a/arch/arm64/boot/dts/rockchip/px30-evb.dts
> b/arch/arm64/boot/dts/rockchip/px30-evb.dts
> index 0a90a88fc664..c9d7b32da997 100644
> --- a/arch/arm64/boot/dts/rockchip/px30-evb.dts
> +++ b/arch/arm64/boot/dts/rockchip/px30-evb.dts
> @@ -189,7 +189,7 @@ rk809: pmic@20 {
>  		interrupts = <7 IRQ_TYPE_LEVEL_LOW>;
>  		pinctrl-names = "default";
>  		pinctrl-0 = <&pmic_int>;
> -		rockchip,system-power-controller;
> +		system-power-controller;
>  		wakeup-source;
>  		#clock-cells = <0>;
>  		clock-output-names = "xin32k";
> diff --git a/arch/arm64/boot/dts/rockchip/px30-firefly-jd4-core.dtsi
> b/arch/arm64/boot/dts/rockchip/px30-firefly-jd4-core.dtsi
> index f18d7eb9a9c7..d22ea65b364c 100644
> --- a/arch/arm64/boot/dts/rockchip/px30-firefly-jd4-core.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/px30-firefly-jd4-core.dtsi
> @@ -70,7 +70,7 @@ rk809: pmic@20 {
>  		interrupts = <7 IRQ_TYPE_LEVEL_LOW>;
>  		pinctrl-names = "default";
>  		pinctrl-0 = <&pmic_int>;
> -		rockchip,system-power-controller;
> +		system-power-controller;
>  		wakeup-source;
>  		#clock-cells = <0>;
>  		clock-output-names = "xin32k";
> diff --git a/arch/arm64/boot/dts/rockchip/px30-ringneck.dtsi
> b/arch/arm64/boot/dts/rockchip/px30-ringneck.dtsi
> index bb1aea82e666..eb0bb78cff7d 100644
> --- a/arch/arm64/boot/dts/rockchip/px30-ringneck.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/px30-ringneck.dtsi
> @@ -127,7 +127,7 @@ rk809: pmic@20 {
>  		pinctrl-names = "default";
>  		#clock-cells = <0>;
>  		clock-output-names = "xin32k";
> -		rockchip,system-power-controller;
> +		system-power-controller;
>  		wakeup-source;
>
>  		vcc1-supply = <&vcc5v0_sys>;