Hi Claudiu, On Wed, Sep 25, 2024 at 9:50 AM claudiu beznea <claudiu.beznea@xxxxxxxxx> wrote: > On 24.09.2024 14:32, Geert Uytterhoeven wrote: > > On Thu, Aug 22, 2024 at 5:28 PM Claudiu <claudiu.beznea@xxxxxxxxx> wrote: > >> From: Claudiu Beznea <claudiu.beznea.uj@xxxxxxxxxxxxxx> > >> > >> The RZ/G3S SYS Controller has 2 registers (one for PCIE one for USB) that > >> need to be configured before/after powering off/on the PCI or USB > >> ares. The bits in these registers control signals to PCIE and USB that > >> need to be de-asserted/asserted after/before power on/off event. For this > >> add SYSC controller driver that registers a reset controller driver on > >> auxiliary bus which allows USB, PCIE drivers to control these signals. > >> > >> Signed-off-by: Claudiu Beznea <claudiu.beznea.uj@xxxxxxxxxxxxxx> > > > > Thanks for your patch! > > > >> --- /dev/null > >> +++ b/drivers/reset/reset-rzg3s-sysc.c > >> @@ -0,0 +1,140 @@ > >> +// SPDX-License-Identifier: GPL-2.0 > >> +/* > >> + * Renesas RZ/G3S SYSC reset driver > >> + * > >> + * Copyright (C) 2024 Renesas Electronics Corp. > >> + */ > >> + > >> +#include <linux/auxiliary_bus.h> > > > > Using the Auxiliary Bus requires selecting AUXILIARY_BUS. > > Thank you for pointing it. I'll adjust it in the next version, if it will > be one. Thanks, the rest LGTM. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds