On Tue, Oct 08, 2024 at 11:28:24AM +0200, Krzysztof Kozlowski wrote: > On 08/10/2024 07:18, Inochi Amaoto wrote: > > On Tue, Oct 08, 2024 at 09:43:52AM +0800, Chen Wang wrote: > >> From: Chen Wang <unicorn_wang@xxxxxxxxxxx> > >> > >> There is a power button on the front panel of the pioneer box. > >> Short pressing the button will trigger the onboard MCU to > >> notify SG2042 through GPIO22 to enter the power-off process. > >> > >> Signed-off-by: Chen Wang <unicorn_wang@xxxxxxxxxxx> > >> --- > >> .../boot/dts/sophgo/sg2042-milkv-pioneer.dts | 15 +++++++++++++++ > >> 1 file changed, 15 insertions(+) > >> > >> diff --git a/arch/riscv/boot/dts/sophgo/sg2042-milkv-pioneer.dts b/arch/riscv/boot/dts/sophgo/sg2042-milkv-pioneer.dts > >> index a3f9d6f22566..be596d01ff8d 100644 > >> --- a/arch/riscv/boot/dts/sophgo/sg2042-milkv-pioneer.dts > >> +++ b/arch/riscv/boot/dts/sophgo/sg2042-milkv-pioneer.dts > >> @@ -5,6 +5,9 @@ > >> > >> #include "sg2042.dtsi" > >> > >> +#include <dt-bindings/gpio/gpio.h> > > > > Just move this include into sg204.dtsi. It seems you forgot to > > sg204.dtsi does not use this header, so why it should be there? > > DTS does not differ here from C. You include only what is being directly > used. > OK, it is my misunderstanding, I thought this header is binded to the GPIO device. Let's drop my advice. Regard, Inochi
