On Mon, Oct 07, 2024 at 10:00:49AM +0200, AngeloGioacchino Del Regno wrote: > Il 06/10/24 17:34, Frank Wunderlich ha scritto: > > From: Frank Wunderlich <frank-w@xxxxxxxxxxxxxxx> > > > > Add binding definitions for mmc on MT7988 SoC. > > > > Signed-off-by: Frank Wunderlich <frank-w@xxxxxxxxxxxxxxx> > > --- > > v2: > > - fixed minItems to 4 > > --- > > .../devicetree/bindings/mmc/mtk-sd.yaml | 24 +++++++++++++++++++ > > 1 file changed, 24 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/mmc/mtk-sd.yaml b/Documentation/devicetree/bindings/mmc/mtk-sd.yaml > > index c532ec92d2d9..7380f72ea189 100644 > > --- a/Documentation/devicetree/bindings/mmc/mtk-sd.yaml > > +++ b/Documentation/devicetree/bindings/mmc/mtk-sd.yaml > > @@ -21,6 +21,7 @@ properties: > > - mediatek,mt7620-mmc > > - mediatek,mt7622-mmc > > - mediatek,mt7986-mmc > > + - mediatek,mt7988-mmc > > - mediatek,mt8135-mmc > > - mediatek,mt8173-mmc > > - mediatek,mt8183-mmc > > @@ -263,6 +264,29 @@ allOf: > > - const: bus_clk > > - const: sys_cg > > + - if: > > + properties: > > + compatible: > > + contains: > > + enum: > > + - mediatek,mt7988-mmc > > Are you really sure that you can't reuse the MT7986 compatible? In OpenWrt we are doing exactly that. The MMC controller of MT7988 (and MT7981) seems 100% the same as in MT7986 and hence works just fine with the mediatek,mt7986-mmc compatible.
