On 07/10/2024 11:26, Kevin Chen wrote: >>>>> diff --git a/arch/arm64/boot/dts/aspeed/aspeed-g7.dtsi >>>>> b/arch/arm64/boot/dts/aspeed/aspeed-g7.dtsi >>>>> new file mode 100644 >>>>> index 000000000000..858ab95251e4 >>>>> --- /dev/null >>>>> +++ b/arch/arm64/boot/dts/aspeed/aspeed-g7.dtsi >>>>> @@ -0,0 +1,217 @@ >>>>> +// SPDX-License-Identifier: GPL-2.0-or-later #include >>>>> +<dt-bindings/clock/aspeed,ast2700-clk.h> >>>>> +#include <dt-bindings/reset/aspeed,ast2700-reset.h> >>>>> +#include <dt-bindings/interrupt-controller/arm-gic.h> >>>>> +#include <dt-bindings/interrupt-controller/aspeed-scu-ic.h> >>>>> + >>>>> +/ { >>>>> + model = "Aspeed BMC"; >>>> >>>> Model of what? No, drop. >>> Can I change to "model = "AST2700 EVB"" >> >> Model of what? No, it does not make sense here. > Should I change to model = "Aspeed BMC SoC"; SoCs do not have models. Please take a look how *every* other SoC is doing. Best regards, Krzysztof