Hi > Gesendet: Montag, 07. Oktober 2024 um 10:00 Uhr > Von: "AngeloGioacchino Del Regno" <angelogioacchino.delregno@xxxxxxxxxxxxx> > Betreff: Re: [PATCH v2 1/2] dt-bindings: mmc: mtk-sd: Add mt7988 SoC > > Il 06/10/24 17:34, Frank Wunderlich ha scritto: > > From: Frank Wunderlich <frank-w@xxxxxxxxxxxxxxx> > > > > Add binding definitions for mmc on MT7988 SoC. > > > > Signed-off-by: Frank Wunderlich <frank-w@xxxxxxxxxxxxxxx> > > --- > > v2: > > - fixed minItems to 4 > > --- > > .../devicetree/bindings/mmc/mtk-sd.yaml | 24 +++++++++++++++++++ > > 1 file changed, 24 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/mmc/mtk-sd.yaml b/Documentation/devicetree/bindings/mmc/mtk-sd.yaml > > index c532ec92d2d9..7380f72ea189 100644 > > --- a/Documentation/devicetree/bindings/mmc/mtk-sd.yaml > > +++ b/Documentation/devicetree/bindings/mmc/mtk-sd.yaml > > @@ -21,6 +21,7 @@ properties: > > - mediatek,mt7620-mmc > > - mediatek,mt7622-mmc > > - mediatek,mt7986-mmc > > + - mediatek,mt7988-mmc > > - mediatek,mt8135-mmc > > - mediatek,mt8173-mmc > > - mediatek,mt8183-mmc > > @@ -263,6 +264,29 @@ allOf: > > - const: bus_clk > > - const: sys_cg > > > > + - if: > > + properties: > > + compatible: > > + contains: > > + enum: > > + - mediatek,mt7988-mmc > > Are you really sure that you can't reuse the MT7986 compatible? have not found a way to reuse mt7986 binding because clock-config is different... from driver view we can use the mt7986 compatible, but from binding view it is different. regards Frank > Cheers, > Angelo > > > + then: > > + properties: > > + clocks: > > + minItems: 4 > > + items: > > + - description: source clock > > + - description: HCLK which used for host > > + - description: Advanced eXtensible Interface > > + - description: Advanced High-performance Bus clock > > + clock-names: > > + minItems: 3 > > + items: > > + - const: source > > + - const: hclk > > + - const: axi_cg > > + - const: ahb_cg > > + > > - if: > > properties: > > compatible: > > >
