Il 06/10/24 17:34, Frank Wunderlich ha scritto:
From: Frank Wunderlich <frank-w@xxxxxxxxxxxxxxx> Add support for mmc on MT7988 SoC. Signed-off-by: Frank Wunderlich <frank-w@xxxxxxxxxxxxxxx>
There's no need to add yet one more duplicate mtk_mmc_compatible platform data, nor one more compatible string to this driver, as this is exactly the same as mt7986. Please reuse the MT7986 compatible; in DT you'll have: compatible = "mediatek,mt7988-mmc", "mediatek,mt7986-mmc"; Cheers, Angelo
--- drivers/mmc/host/mtk-sd.c | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/drivers/mmc/host/mtk-sd.c b/drivers/mmc/host/mtk-sd.c index 89018b6c97b9..6d5afe51a61d 100644 --- a/drivers/mmc/host/mtk-sd.c +++ b/drivers/mmc/host/mtk-sd.c @@ -571,6 +571,19 @@ static const struct mtk_mmc_compatible mt7986_compat = { .support_64g = true, };+static const struct mtk_mmc_compatible mt7988_compat = {+ .clk_div_bits = 12, + .recheck_sdio_irq = true, + .hs400_tune = false, + .pad_tune_reg = MSDC_PAD_TUNE0, + .async_fifo = true, + .data_tune = true, + .busy_check = true, + .stop_clk_fix = true, + .enhance_rx = true, + .support_64g = true, +}; + static const struct mtk_mmc_compatible mt8135_compat = { .clk_div_bits = 8, .recheck_sdio_irq = true, @@ -629,6 +642,7 @@ static const struct of_device_id msdc_of_ids[] = { { .compatible = "mediatek,mt7620-mmc", .data = &mt7620_compat}, { .compatible = "mediatek,mt7622-mmc", .data = &mt7622_compat}, { .compatible = "mediatek,mt7986-mmc", .data = &mt7986_compat}, + { .compatible = "mediatek,mt7988-mmc", .data = &mt7988_compat}, { .compatible = "mediatek,mt8135-mmc", .data = &mt8135_compat}, { .compatible = "mediatek,mt8173-mmc", .data = &mt8173_compat}, { .compatible = "mediatek,mt8183-mmc", .data = &mt8183_compat},
