On 10/7/24 15:54, Krzysztof Kozlowski wrote: > On 07/10/2024 08:50, Damien Le Moal wrote: >> On 10/7/24 15:12, Krzysztof Kozlowski wrote: >>> On Mon, Oct 07, 2024 at 01:12:17PM +0900, Damien Le Moal wrote: >>>> From: Wilfred Mallawa <wilfred.mallawa@xxxxxxx> >>>> >>>> Describe the `ep-gpios` property which is used to map the PERST# input >>>> signal for endpoint mode. >>> >>> Why "ep" for PERST signal? Looks totally unrelated name. There is >>> already reset-gpios exactly for PERST, so you are duplicating it. Why? >> >> Because the host side controller already has the same "ep-gpios" property. >> >> Documentation/devicetree/bindings/pci/rockchip,rk3399-pcie.yaml > > If host has it, then it is a common property so goes to common schema > for these devices. Ah. OK. I will move it to Documentation/devicetree/bindings/pci/rockchip,rk3399-pcie-common.yaml then. >> So naming that property the same allows common code to initialize that gpio in >> rockchip_pcie_parse_dt(). >> >> Also, I do not see reset-gpios being defined/used by this driver (host and ep >> sides). > > I am talking about bindings, not driver. I do not see reset-gpios being defined in the bindings (common, host and ep). resets and reset-names are defined though but these have nothing to do with #PERST control. -- Damien Le Moal Western Digital Research
