Hi Wolfram, On Sat, Sep 28, 2024 at 11:30 AM Wolfram Sang <wsa+renesas@xxxxxxxxxxxxxxxxxxxx> wrote: > For this to work, User LEDs must be disabled because they share their > pins with SD data lines. > > Signed-off-by: Wolfram Sang <wsa+renesas@xxxxxxxxxxxxxxxxxxxx> Thanks for your patch! > --- a/arch/arm/boot/dts/renesas/r7s72100-genmai.dts > +++ b/arch/arm/boot/dts/renesas/r7s72100-genmai.dts > @@ -244,6 +257,14 @@ &scif2 { > status = "okay"; > }; > > +&sdhi0 { > + pinctrl-names = "default"; > + pinctrl-0 = <&sdhi0_pins>; > + > + bus-width = <4>; > + status = "okay"; Any specific reason you left out the regulator for SDHI (CVCC1), but did add the regulator for MMC (CVCC2) in PATCH 2/3? > +}; > + > &spi4 { > status = "okay"; The rest LGTM. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds